Spring/spring-security-kerberos
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Handle possible NPE bug in some jkd versions.

Browse Source 
- Check if GSSContext initiator is null, which it should
  not be, and throw BadCredentialsException instead of NPE.
This commit is contained in:
Janne Valkealahti
2015-04-22 11:55:22 +01:00
parent 9a6165d7dc
commit f046bd7c69
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-security-kerberos-core/src/main/java/org/springframework/security/kerberos/authentication/sun/SunJaasKerberosTicketValidator.java
View File

@@ -33,6 +33,7 @@ import org.apache.commons.logging.LogFactory;
import org.ietf.jgss.GSSContext;
import org.ietf.jgss.GSSCredential;
import org.ietf.jgss.GSSManager;
import org.ietf.jgss.GSSName;
import org.springframework.beans.factory.InitializingBean;
import org.springframework.core.io.ClassPathResource;
import org.springframework.core.io.Resource;
@@ -159,11 +160,14 @@ public class SunJaasKerberosTicketValidator implements KerberosTicketValidator,
public KerberosTicketValidation run() throws Exception {
GSSContext context = GSSManager.getInstance().createContext((GSSCredential) null);
byte[] responseToken = context.acceptSecContext(kerberosTicket, 0, kerberosTicket.length);
String user = context.getSrcName().toString();
GSSName gssName = context.getSrcName();
if (gssName == null) {
throw new BadCredentialsException("GSSContext name of the context initiator is null");
}
if (!holdOnToGSSContext) {
context.dispose();
}
return new KerberosTicketValidation(user, servicePrincipal, responseToken, context);
return new KerberosTicketValidation(gssName.toString(), servicePrincipal, responseToken, context);
}
}