Spring/spring-session-data-geode
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Replace Optional.ofNullable(:Session) with a conditional and a new, private isNonNullAndDirty(:Session) method.

Browse Source
This commit is contained in:
John Blum
2018-12-03 18:37:04 -08:00
parent 8e1f5a58f6
commit e56541949f
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
spring-session-data-geode/src/main/java/org/springframework/session/data/gemfire/GemFireOperationsSessionRepository.java
View File

@@ -19,7 +19,6 @@ package org.springframework.session.data.gemfire;
import java.time.Duration;
import java.util.HashMap;
import java.util.Map;
import java.util.Optional;
import org.apache.geode.cache.query.SelectResults;
@@ -155,15 +154,19 @@ public class GemFireOperationsSessionRepository extends AbstractGemFireOperation
*/
public void save(@Nullable Session session) {
Optional.ofNullable(session)
.filter(this::isDirty)
.ifPresent(this::doSave);
if (isNonNullAndDirty(session)) {
doSave(session);
}
}
private boolean isDirty(@NonNull Session session) {
return !(session instanceof GemFireSession) || ((GemFireSession) session).hasDelta();
}
private boolean isNonNullAndDirty(@Nullable Session session) {
return session != null && isDirty(session);
}
void doSave(@NonNull Session session) {
// Save Session As GemFireSession