Commit Graph

690 Commits

Author SHA1 Message Date
github-actions[bot]
02c3999508 Next development version 2023-06-27 07:00:52 +00:00
Janne Valkealahti
a7e62076c2 Add run-name to release workflow 2023-06-27 07:42:48 +01:00
Janne Valkealahti
24496d469c Upgrade spring-boot 2.7.13
- Fixes #784
2023-06-22 15:50:34 +01:00
Janne Valkealahti
b5159dffbe Revert "ExtendedDefaultParser should not add empty arguments"
This reverts commit c1c9f5e2c2.

Relates #765
2023-06-12 09:05:30 +01:00
Janne Valkealahti
c1c9f5e2c2 ExtendedDefaultParser should not add empty arguments
- Fixes issue when last "word" is within quotes and
  cursor is at the end of a line which caused empty
  "word" string in an argument list.
- This then caused i.e. string option to have a collection
  as an input(if no arity settings used) and via
  spring conversions a comma were added.
- Backport #763
- Fixes #765
2023-06-07 16:01:22 +01:00
Janne Valkealahti
a4359e7c56 Fix ci publish 2023-05-29 06:57:45 +01:00
Janne Valkealahti
3115274fc4 Fix ci publish 2023-05-29 06:51:29 +01:00
Janne Valkealahti
348f959c42 Fix ci publish 2023-05-29 06:40:45 +01:00
Janne Valkealahti
96d4a777f4 Fix ci publish 2023-05-28 17:52:05 +01:00
Janne Valkealahti
07fcc754e8 Fix ci publish 2023-05-28 17:36:13 +01:00
Janne Valkealahti
21c411abbf Fix ci publish 2023-05-28 17:07:11 +01:00
github-actions[bot]
b8dece2ee2 Next development version 2023-05-25 15:12:52 +00:00
Janne Valkealahti
0208805d43 Add input into ConfirmationInput
- Now displaying what user actually inputs
- Backport #740
- Fixes #745
2023-05-20 17:23:57 +01:00
Janne Valkealahti
33eb30e566 Upgrade spring-boot 2.7.12
- Fixes #741
2023-05-19 08:29:23 +01:00
github-actions[bot]
b4d1039cbe Next development version 2023-05-08 08:02:12 +00:00
Janne Valkealahti
4cff994e1d Upgrade jline 3.23.0
- Backport #725
- Fixes #726
2023-04-29 14:58:10 +01:00
Janne Valkealahti
60287c7459 Migrate docs to spring-asciidoctor-backends
- Use io.spring.asciidoctor.backends:spring-asciidoctor-backends:0.0.5
- Backport #722
- Fixes #723
2023-04-29 08:06:32 +01:00
Janne Valkealahti
efe8d561fd Upgrade spring-boot 2.7.11
-Fixes #719
2023-04-27 20:52:58 +01:00
github-actions[bot]
8572eeef93 Next development version 2023-04-11 17:35:48 +00:00
cachescrubber
f3e3061580 Pass ShellContext to CommandCatalog.of in CommandCatalogAutoConfiguration (#693)
- Backport #702
- Fixes #703
2023-04-06 09:16:34 +01:00
Janne Valkealahti
78faeac86a Fix build with jdk8
- Remove non jdk8 code used in #694
2023-04-06 07:18:53 +01:00
Janne Valkealahti
041cb30eb0 Fix option type parsing
- In `CommandRegistration` add `ResolvableType` for `OptionSpec` giving
  more spesific handling of a type.
- In `CommandParser` handle source and target types so that we
  have generics with `List`, `Set` and arrays working better.
- In `HandlerMethodArgumentResolver` add better handling for
  `ConversionService` for generic types.
- In `StandardMethodTargetRegistrar` add better types via `ResolvableType`
  now that `CommandRegistration` support it.
- In `OptionConversionCommands` remove converter from `String` to `Set` as
  now things should work as is if generic in a `Set` has a converter.
- Fixes #694
2023-04-02 14:37:08 +01:00
Janne Valkealahti
77b136f53f Upgrade spring-boot 2.7.10
- Fixes #696
2023-03-24 07:48:26 +00:00
Janne Valkealahti
5e0c79cb2a Update docs copyright year 2023-03-18 16:51:49 +00:00
Janne Valkealahti
de08935b92 Fix ConfirmationInput template message
- Fix confirmation-input-default.stg to use correct style
  names in format.
- Backport #690
- Fixes #692
2023-03-17 08:43:52 +00:00
Simon Verhoeven
3c090848bf Rename setMaskCharater to setMaskCharacter
- Backport #686
- Fixes #689
2023-03-12 16:12:28 +00:00
github-actions[bot]
b4f2598417 Next development version 2023-02-27 17:26:44 +00:00
Janne Valkealahti
d9641f6d1c Wrong arity for default boolean type
- Set boolean type arity zero or more as default.
- Backport #675
- Fixes #677
2023-02-27 15:44:35 +00:00
Janne Valkealahti
339b43b5e3 Upgrade spring-boot 2.7.9
- Fixes #660
2023-02-23 18:14:11 +00:00
Janne Valkealahti
d72627443c Rename command registration doc files 2023-02-23 09:57:33 +00:00
Janne Valkealahti
545a735dd9 Move command registration under same section 2023-02-23 09:28:48 +00:00
Janne Valkealahti
7ec5c194ff Use correct type with set
- When target is set and only one option argument is given,
  we should not convert to list as user expects string to xxx
  Converter to work.
- This is how it used to work and previous changes caused
  regression.
- Bug is actually in an old parser and new parser works fine.
- Backport #667
- Fixes #669
2023-02-18 14:21:08 +00:00
Janne Valkealahti
3c44c7c976 Handle arg looking options better
- Now lexing better with valid options
- Only report unrecognised option with double dash
  as current parser don't have structure to do
  deeper analysis.
- Backport #651
- Fixes #653
2023-02-01 09:43:36 +00:00
Janne Valkealahti
ca76a63c30 CommandRegistration should return same options
- Cache created CommandOption(s) to return same instance.
- Backport #648
- Fixes #649
2023-01-28 17:50:45 +00:00
github-actions[bot]
61ab2de48c Next development version 2023-01-24 09:28:38 +00:00
Janne Valkealahti
9154c85762 Use nexus-sync v0 2023-01-23 10:51:57 +00:00
Janne Valkealahti
5c52fbe373 Polish 2023-01-20 16:11:42 +00:00
Janne Valkealahti
a7d31c1126 Upgrade spring-boot 2.7.8
- Fixes #620
2023-01-20 09:53:49 +00:00
Janne Valkealahti
21d695f68e Fix sample commands
- Fix mistake made in backport #631 which
  caused compile issues.
2023-01-19 18:01:27 +00:00
Janne Valkealahti
1bc26c7e17 Handle collection types in a parser
- Handle any option collection type so that list is generated for
  values, this then works well when actual type conversions happen.
- Backport #630
- Fixes #631
2023-01-19 17:34:43 +00:00
Janne Valkealahti
78da071e86 Document String array option type
- Backport #558 as it brings missing option type docs
- Backport #628
- Fixes #629
2023-01-19 11:59:53 +00:00
Janne Valkealahti
b853112e0b Replace parser string joining with list
- Issue in #622 is that its command type is `String` and internally
  some incoming arguments(it's List) were converted to String by
  joining with space. This caused one case with help command to get
  conversion via spring's ConversionService(CollectionToStringConverter)
  which joins by commas. That was we saw in failed example.
- Remove needed joins in CommandParser and let it just pass List which
  then works better with ConversionService.
- This then needs a `command` option type change from String to String[]
  which it really is as you should be able to give whole command as
  an argument.
- Backport #622
- Fixes #623
2023-01-16 21:03:47 +00:00
Janne Valkealahti
7c91782841 Revisit positional arguments
- Add better mapping logic
- Add better type conversion
- More docs for arity and positional option configuration
- Backport #616
- Fixes #617
2023-01-13 17:56:24 +00:00
Janne Valkealahti
4381c2423e Handle arity errors
- Introduce new error TooManyArgumentsOptionException
  and NotEnoughArgumentsOptionException.
- Parser not tracks arity min/max and imposes
  if num of option arguments.
- Backport #614
- Fixes #615
- Original commit this sources had some additional changes
  which is not possible to merge.
2023-01-13 17:53:54 +00:00
Janne Valkealahti
6e3d43c549 Fix sample
- Remove use of CommandRegistration.Builder supplier
- #618
2023-01-13 17:40:31 +00:00
github-actions[bot]
8179401268 Next development version 2023-01-10 14:47:40 +00:00
Janne Valkealahti
c1604021c6 Use nexus-sync 0.0.x 2023-01-10 13:01:58 +00:00
Janne Valkealahti
38acd79b83 Add unrecognised option support
- This commit modifies CommandParser to better track positional parameters
  which previously used to go there for non-recognised options. Now using
  relatively dump logic of just checking if first positional parameter starts
  with '-' which indicates it's a candidate for a new `UnrecognisedOptionException`
  which then would give user an error "Unrecognised option '--xxx'" for example.
- Backport #601
- Backport #602
- Fixes #603
- Fixes #604
2023-01-07 09:08:15 +00:00
Janne Valkealahti
800e249b98 Fix NPE
- Backport #593
- Fixes #598
2023-01-01 15:12:48 +00:00
Janne Valkealahti
dd84beafcb Upgrade spring-boot 2.7.7
- Fixes #595
2022-12-27 15:56:31 +00:00