Add configuration tests for StateMachineModelFactory

- While original issue is already fixed in 1.2.x, adding
  specific tests for checking if config is coming from model
  or adapter.
- Fixes #459
This commit is contained in:
Janne Valkealahti
2017-12-22 09:23:10 +00:00
parent 7c8b93bd45
commit 12a48ee443

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2016 the original author or authors.
* Copyright 2016-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,10 +16,12 @@
package org.springframework.statemachine.config.model;
import static org.hamcrest.Matchers.contains;
import static org.hamcrest.Matchers.is;
import static org.junit.Assert.assertThat;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
import org.junit.Test;
import org.springframework.beans.BeansException;
@@ -31,13 +33,17 @@ import org.springframework.context.annotation.Configuration;
import org.springframework.statemachine.AbstractStateMachineTests;
import org.springframework.statemachine.StateContext;
import org.springframework.statemachine.StateMachine;
import org.springframework.statemachine.TestUtils;
import org.springframework.statemachine.action.Action;
import org.springframework.statemachine.config.EnableStateMachine;
import org.springframework.statemachine.config.EnableStateMachineFactory;
import org.springframework.statemachine.config.ObjectStateMachineFactory;
import org.springframework.statemachine.config.StateMachineConfigurerAdapter;
import org.springframework.statemachine.config.StateMachineFactory;
import org.springframework.statemachine.config.builders.StateMachineConfigurationConfigurer;
import org.springframework.statemachine.config.builders.StateMachineModelConfigurer;
import org.springframework.statemachine.listener.StateMachineListener;
import org.springframework.statemachine.listener.StateMachineListenerAdapter;
public class StateMachineModelFactoryTests extends AbstractStateMachineTests {
@@ -97,6 +103,32 @@ public class StateMachineModelFactoryTests extends AbstractStateMachineTests {
stateMachine.stop();
}
@Test
public void testConfigAdapterConfigFromModel() throws Exception {
context.register(Config4.class);
context.refresh();
@SuppressWarnings("unchecked")
StateMachine<String, String> stateMachine = context.getBean(StateMachine.class);
Object o1 = TestUtils.readField("stateListener", stateMachine);
Object o2 = TestUtils.readField("listeners", o1);
Object o3 = TestUtils.readField("list", o2);
assertThat(((List<?>)o3).size(), is(0));
}
@Test
public void testConfigAdapterConfigFromAdapter() throws Exception {
context.register(Config5.class);
context.refresh();
@SuppressWarnings("unchecked")
StateMachine<String, String> stateMachine = context.getBean(StateMachine.class);
Object o1 = TestUtils.readField("stateListener", stateMachine);
Object o2 = TestUtils.readField("listeners", o1);
Object o3 = TestUtils.readField("list", o2);
assertThat(((List<?>)o3).size(), is(1));
}
@Configuration
static class Config1 {
@Bean
@@ -161,6 +193,82 @@ public class StateMachineModelFactoryTests extends AbstractStateMachineTests {
}
}
@Configuration
@EnableStateMachine
public static class Config4 extends StateMachineConfigurerAdapter<String, String> {
@Override
public void configure(StateMachineConfigurationConfigurer<String, String> config) throws Exception {
config
.withConfiguration()
.listener(stateMachineListener());
}
@Override
public void configure(StateMachineModelConfigurer<String, String> model) throws Exception {
model
.withModel()
.factory(modelFactory());
}
@Bean
public StateMachineModelFactory<String, String> modelFactory() {
return new TestStateMachineModelFactory();
}
@Bean
public Action<String, String> action1() {
return new Action<String, String>() {
@Override
public void execute(StateContext<String, String> context) {
}
};
}
@Bean
public StateMachineListener<String, String> stateMachineListener() {
return new StateMachineListenerAdapter<String, String>(){};
}
}
@Configuration
@EnableStateMachine
public static class Config5 extends StateMachineConfigurerAdapter<String, String> {
@Override
public void configure(StateMachineConfigurationConfigurer<String, String> config) throws Exception {
config
.withConfiguration()
.listener(stateMachineListener());
}
@Override
public void configure(StateMachineModelConfigurer<String, String> model) throws Exception {
model
.withModel()
.factory(modelFactory());
}
@Bean
public StateMachineModelFactory<String, String> modelFactory() {
return new TestStateMachineModelFactory2();
}
@Bean
public Action<String, String> action1() {
return new Action<String, String>() {
@Override
public void execute(StateContext<String, String> context) {
}
};
}
@Bean
public StateMachineListener<String, String> stateMachineListener() {
return new StateMachineListenerAdapter<String, String>(){};
}
}
@SuppressWarnings("unchecked")
private static class TestStateMachineModelFactory implements StateMachineModelFactory<String, String>, BeanFactoryAware {
private BeanFactory beanFactory;
@@ -201,6 +309,44 @@ public class StateMachineModelFactoryTests extends AbstractStateMachineTests {
}
}
@SuppressWarnings("unchecked")
private static class TestStateMachineModelFactory2 implements StateMachineModelFactory<String, String>, BeanFactoryAware {
private BeanFactory beanFactory;
String state1 = "S1";
String state2 = "S2";
String event1 = "E1";
@Override
public StateMachineModel<String, String> build() {
Action<String, String> action1 = beanFactory.getBean("action1", Action.class);
Collection<Action<String, String>> s2Actions = new ArrayList<>();
s2Actions.add(action1);
Collection<StateData<String, String>> stateData = new ArrayList<>();
stateData.add(new StateData<String, String>(state1, true));
stateData.add(new StateData<String, String>(null, null, state2, null, s2Actions, null));
StatesData<String, String> statesData = new StatesData<>(stateData);
Collection<TransitionData<String, String>> transitionData = new ArrayList<>();
transitionData.add(new TransitionData<String, String>(state1, state2, event1));
TransitionsData<String, String> transitionsData = new TransitionsData<>(transitionData);
StateMachineModel<String, String> stateMachineModel = new DefaultStateMachineModel<>(null, statesData, transitionsData);
return stateMachineModel;
}
@Override
public void setBeanFactory(BeanFactory beanFactory) throws BeansException {
this.beanFactory = beanFactory;
}
@Override
public StateMachineModel<String, String> build(String machineId) {
return build();
}
}
@Override
protected AnnotationConfigApplicationContext buildContext() {
return new AnnotationConfigApplicationContext();