replaced a number of print stack trace statements with proper logging

This commit is contained in:
Martin Lippert
2024-04-22 09:58:20 +02:00
parent 54ce28c2ff
commit 12d2c24a03
2 changed files with 14 additions and 6 deletions

View File

@@ -31,6 +31,8 @@ import org.eclipse.jdt.core.dom.NormalAnnotation;
import org.eclipse.jdt.core.dom.SingleMemberAnnotation;
import org.eclipse.jdt.core.dom.TypeDeclaration;
import org.eclipse.lsp4j.Location;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.ide.vscode.boot.java.Annotations;
import org.springframework.ide.vscode.boot.java.handlers.AbstractSymbolProvider;
import org.springframework.ide.vscode.boot.java.utils.ASTUtils;
@@ -47,6 +49,8 @@ public class RequestMappingSymbolProvider extends AbstractSymbolProvider {
private static final Set<String> ATTRIBUTE_NAME_METHOD = Set.of("method");
private static final Set<String> ATTRIBUTE_NAME_CONSUMES = Set.of("consumes");
private static final Set<String> ATTRIBUTE_NAME_PRODUCES = Set.of("produces");
private static final Logger log = LoggerFactory.getLogger(RequestMappingSymbolProvider.class);
@Override
protected void addSymbolsPass1(Annotation node, ITypeBinding annotationType, Collection<ITypeBinding> metaAnnotations, SpringIndexerJavaContext context, TextDocument doc) {
@@ -69,7 +73,7 @@ public class RequestMappingSymbolProvider extends AbstractSymbolProvider {
.map(p -> RouteUtils.createRouteSymbol(location, p, methods, contentTypes, acceptTypes, null))
.forEach((enhancedSymbol) -> context.getGeneratedSymbols().add(new CachedSymbol(context.getDocURI(), context.getLastModified(), enhancedSymbol)));
} catch (Exception e) {
e.printStackTrace();
log.error("problem occured while scanning for request mapping symbols from " + doc.getUri(), e);
}
}
}

View File

@@ -30,6 +30,8 @@ import org.eclipse.jdt.core.dom.Type;
import org.eclipse.jdt.core.dom.TypeDeclaration;
import org.eclipse.lsp4j.Location;
import org.eclipse.lsp4j.Range;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.ide.vscode.boot.java.handlers.AbstractSymbolProvider;
import org.springframework.ide.vscode.boot.java.handlers.EnhancedSymbolInformation;
import org.springframework.ide.vscode.boot.java.handlers.SymbolAddOnInformation;
@@ -43,6 +45,8 @@ import org.springframework.ide.vscode.commons.util.text.TextDocument;
* @author Martin Lippert
*/
public class WebfluxRouterSymbolProvider extends AbstractSymbolProvider {
private static final Logger log = LoggerFactory.getLogger(WebfluxRouterSymbolProvider.class);
@Override
public void addSymbols(MethodDeclaration methodDeclaration, SpringIndexerJavaContext context, TextDocument doc) {
@@ -115,7 +119,7 @@ public class WebfluxRouterSymbolProvider extends AbstractSymbolProvider {
context.getGeneratedSymbols().add(new CachedSymbol(context.getDocURI(), context.getLastModified(), enhancedSymbol));
} catch (BadLocationException e) {
e.printStackTrace();
log.error("bad location while extracting mapping symbol for " + doc.getUri(), e);
}
}
}
@@ -158,7 +162,7 @@ public class WebfluxRouterSymbolProvider extends AbstractSymbolProvider {
}
}
catch (BadLocationException e) {
// ignore
log.error("bad location while extracting mapping symbol for " + doc.getUri(), e);
}
return null;
});
@@ -190,7 +194,7 @@ public class WebfluxRouterSymbolProvider extends AbstractSymbolProvider {
}
}
catch (BadLocationException e) {
// ignore
log.error("bad location while extracting mapping symbol for " + doc.getUri(), e);
}
return null;
@@ -223,7 +227,7 @@ public class WebfluxRouterSymbolProvider extends AbstractSymbolProvider {
}
}
catch (BadLocationException e) {
// ignore
log.error("bad location while extracting mapping symbol for " + doc.getUri(), e);
}
return null;
@@ -256,7 +260,7 @@ public class WebfluxRouterSymbolProvider extends AbstractSymbolProvider {
}
}
catch (BadLocationException e) {
// ignore
log.error("bad location while extracting mapping symbol for " + doc.getUri(), e);
}
return null;