Spring/spring-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Propagate CF hints errors to framework

Browse Source
This commit is contained in:
nsingh
2017-01-19 16:41:36 -08:00
parent bed871e5f5
commit 1e74028539
1 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
vscode-extensions/vscode-manifest-yaml/src/main/java/org/springframework/ide/vscode/manifest/yaml/AbstractCFHintsProvider.java
View File

@@ -49,22 +49,27 @@ public abstract class AbstractCFHintsProvider implements Callable<Collection<YVa
Collection<YValueHint> resolvedHints = getHints(targets);
hints.addAll(resolvedHints);
} catch (Throwable e) {
// Don't log the no target found error. Just inform the user
if (ExceptionUtil.getThrowable(e, NoTargetsException.class) != null) {
hints.add(new BasicYValueHint(EMPTY_VALUE, e.getMessage()));
} else {
// Convert any non "no-target" errors to something useful. The
// "no-target" errors
// are generated by the target provider so they should be propagated
// as is without further
// transformation
if (ExceptionUtil.getThrowable(e, NoTargetsException.class) == null) {
// Log any other error
logger.log(Level.SEVERE, e.getMessage(), e);
if (ExceptionUtil.getThrowable(e, IOException.class) != null) {
hints.add(new BasicYValueHint(EMPTY_VALUE,
"Connection failure to Cloud Foundry. Please check the log for more details."));
throw ExceptionUtil.exception(
"Connection failure to Cloud Foundry. Please check the log for more details.", e);
} else {
hints.add(new BasicYValueHint(EMPTY_VALUE,
"Failed to fetch values from Cloud Foundry. Please check the log for more details."));
throw ExceptionUtil.exception(
"Failed to fetch values from Cloud Foundry. Please check the log for more details.", e);
}
}
else {
throw e;
}
}
return hints;
}