Spring/spring-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

try with resource when reading symbol cache data to avoid leaking file handles

Browse Source
This commit is contained in:
Martin Lippert
2019-08-07 16:47:48 +02:00
parent 2768a29f09
commit 379f3c102a
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/utils/SymbolCacheOnDisc.java
View File

@@ -99,11 +99,12 @@ public class SymbolCacheOnDisc implements SymbolCache {
@Override
public Pair<CachedSymbol[], Multimap<String, String>> retrieve(SymbolCacheKey cacheKey, String[] files) {
try {
File cacheStore = new File(cacheDirectory, cacheKey.toString() + ".json");
if (cacheStore.exists()) {
Gson gson = createGson();
JsonReader reader = new JsonReader(new FileReader(cacheStore));
File cacheStore = new File(cacheDirectory, cacheKey.toString() + ".json");
if (cacheStore.exists()) {
Gson gson = createGson();
try (JsonReader reader = new JsonReader(new FileReader(cacheStore))) {
CacheStore store = gson.fromJson(reader, CacheStore.class);
SortedMap<String, Long> timestampedFiles = Arrays.stream(files)
@@ -133,9 +134,9 @@ public class SymbolCacheOnDisc implements SymbolCache {
);
}
}
}
catch (Exception e) {
log.error("error reading cached symbols", e);
catch (Exception e) {
log.error("error reading cached symbols", e);
}
}
return null;
}