Spring/spring-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix NPE that happens on restart of local apps ...

Browse Source 
... and is suspected of causing resource leak by
breaking proper disposal of JMX connectors for local apps.
This commit is contained in:
Kris De Volder
2018-08-09 11:56:21 -07:00
parent 65d2f5291f
commit 3b0fb2135a
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
headless-services/commons/commons-boot-app-cli/src/main/java/org/springframework/ide/vscode/commons/boot/app/cli/AbstractSpringBootApp.java
View File

@@ -51,6 +51,7 @@ import javax.management.remote.JMXServiceURL;
import com.google.common.collect.ImmutableList;
import com.google.gson.Gson;
import com.google.gson.GsonBuilder;
import com.sun.jdi.connect.Connector;
/**
* A abstract base class which attempts to capture commonalities between
@@ -89,7 +90,9 @@ public abstract class AbstractSpringBootApp implements SpringBootApp {
String url = getJmxUrl();
logger.info("Creating JMX connector: "+url);
try {
return JMXConnectorFactory.connect(new JMXServiceURL(url), null);
JMXConnector connector = JMXConnectorFactory.connect(new JMXServiceURL(url), null);
logger.info("Created JMX connector: {}", connector);
return connector;
} catch (Exception e) {
logger.info("Creating JMX connector failed: {}", ExceptionUtil.getMessage(e));
throw e;
@@ -98,7 +101,7 @@ public abstract class AbstractSpringBootApp implements SpringBootApp {
//disposing jmx connector:
(connector) -> {
try {
logger.info("Disposing JMX connector: "+getJmxUrl());
logger.info("Disposing JMX connector: "+connector);
connector.close();
} catch (IOException e) {
//ignore