Spring/spring-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

improve log output for error cases by showing more details about what exactly went wrong

Browse Source
This commit is contained in:
Martin Lippert
2022-12-23 16:02:52 +01:00
parent ee917fbbdb
commit 565dcdf782
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/util/SimpleLanguageServer.java
View File

@@ -754,7 +754,8 @@ public final class SimpleLanguageServer implements Sts4LanguageServer, LanguageC
public void accept(ReconcileProblem problem) {
try {
DiagnosticSeverity severity = severityProvider.getDiagnosticSeverity(problem);
if (severity!=null) {
if (severity != null) {
Diagnostic d = new Diagnostic();
d.setCode(problem.getCode());
d.setMessage(problem.getMessage());
@@ -763,6 +764,7 @@ public final class SimpleLanguageServer implements Sts4LanguageServer, LanguageC
d.setSeverity(severity);
d.setSource(getServer().EXTENSION_ID);
List<QuickfixData<?>> fixes = problem.getQuickfixes();
// Copy original diagnsotic without the data field to avoid stackoverflow is hashCode() method call
Diagnostic refDiagnostic = new Diagnostic(d.getRange(), d.getMessage(), d.getSeverity(), d.getSource());
if (CollectionUtil.hasElements(fixes)) {
@@ -782,7 +784,7 @@ public final class SimpleLanguageServer implements Sts4LanguageServer, LanguageC
diagnostics.add(d);
}
} catch (BadLocationException e) {
log.warn("Invalid reconcile problem ignored", e);
log.warn("Invalid reconcile problem ignored: " + doc.getUri() + " - problem position: " + problem.getOffset() + "/" + problem.getLength(), e);
}
}
};

2
headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/validation/generations/ProjectVersionDiagnosticProvider.java
View File

@@ -38,7 +38,7 @@ public class ProjectVersionDiagnosticProvider {
URI buildFileUri = javaProject.getProjectBuild() == null ? null : javaProject.getProjectBuild().getBuildFile();
if (buildFileUri == null) {
throw new Exception("Unable to find build file in project while computing version validation for: ");
throw new Exception("Unable to find build file in project while computing version validation for: " + javaProject.getElementName());
}
Version javaProjectVersion = SpringProjectUtil.getSpringBootVersion(javaProject);