Spring/spring-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

filed and added corresponding JDT parser issues for disabled test cases around code completion difficulties

Browse Source
This commit is contained in:
Martin Lippert
2024-12-09 13:47:55 +01:00
parent 4e7dccb36c
commit 7b83098124
2 changed files with 14 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
headless-services/spring-boot-language-server/src/test/java/org/springframework/ide/vscode/boot/java/conditionals/test/ConditionalOnPropertyCompletionTest.java
View File

@@ -189,7 +189,7 @@ public class ConditionalOnPropertyCompletionTest {
}
@Test
@Disabled
@Disabled // https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3260
public void testConditionalOnPropertyCompletionWithPrefixAndAttributeWithNameAttribute() throws Exception {
List<CompletionItem> completions = getCompletions("@ConditionalOnProperty(prefix = \"else\", name=<*>)");
assertEquals(1, completions.size());
@@ -210,7 +210,7 @@ public class ConditionalOnPropertyCompletionTest {
}
@Test
@Disabled
@Disabled // https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3419
public void testConditionalOnPropertyCompletionWithEmptyPrefixAndEmptyNameAttribute() throws Exception {
List<CompletionItem> completions = getCompletions("@ConditionalOnProperty(prefix = , name = <*>)");
assertEquals(3, completions.size());
@@ -221,7 +221,7 @@ public class ConditionalOnPropertyCompletionTest {
}
@Test
@Disabled
@Disabled // https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3419
public void testConditionalOnPropertyCompletionWithEmptyPrefixAndEmptyNameAttributeInQuotes() throws Exception {
List<CompletionItem> completions = getCompletions("@ConditionalOnProperty(prefix = , name = \"<*>\")");
assertEquals(3, completions.size());

27
headless-services/spring-boot-language-server/src/test/java/org/springframework/ide/vscode/boot/java/value/test/ValueCompletionTest.java
View File

@@ -288,10 +288,8 @@ public class ValueCompletionTest {
assertClasspathCompletions();
}
// The parser removes the (spring.) piece from the AST in this case, so there is no way
// to clearly identify this case
@Test
@Disabled
@Disabled // https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3420
void testComplexPrefixCompletionParamNameCursorRightAfterDot() throws Exception {
prepareCase("@Value(\"onField\")", "@Value(spring.<*>)");
@@ -321,19 +319,16 @@ public class ValueCompletionTest {
assertClasspathCompletions();
}
// The parser removes the (spring.) piece from the AST in this case, so there is no way
// to clearly identify this case
//
// @Test
// void testPrefixCompletionWithParamNameCursorRightAfterDot() throws Exception {
// prepareCase("@Value(\"onField\")", "@Value(value=spring.<*>)");
// prepareDefaultIndexData();
//
// assertPropertyCompletions(
// "@Value(value=\"${spring.prop1}\"<*>)");
//
// assertClasspathCompletions();
// }
@Test
@Disabled // https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3421
void testPrefixCompletionWithParamNameCursorRightAfterDot() throws Exception {
prepareCase("@Value(\"onField\")", "@Value(value=spring.<*>)");
assertPropertyCompletions(
"@Value(value=\"${spring.prop1}\"<*>)");
assertClasspathCompletions();
}
@Test
void testComplexPrefixCompletionWithParamName() throws Exception {