Spring/spring-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove live hover optimisation

Browse Source 
Does not work when stopping running apps and having multiple editors
open.
This commit is contained in:
nsingh
2018-05-10 09:59:27 -07:00
parent f56c0fe59b
commit a640a62121
2 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
headless-services/commons/language-server-test-harness/src/main/java/org/springframework/ide/vscode/languageserver/testharness/Editor.java
View File

@@ -209,8 +209,7 @@ public class Editor {
public List<Range> assertHighlights(String... expectedHighlights) throws Exception {
HighlightParams highlights = expectedHighlights == null || expectedHighlights.length == 0 ? harness.getHighlights(false, doc)
: harness.getHighlights(doc);
HighlightParams highlights = harness.getHighlights(doc);
List<Range> ranges = highlights != null ? new ArrayList<>(highlights.getRanges()) : ImmutableList.of();
Collections.sort(ranges, RANGE_COMPARATOR);
List<String> actualHighlights = ranges.stream()

11
headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/utils/SpringLiveHoverWatchdog.java
View File

@@ -49,7 +49,6 @@ public class SpringLiveHoverWatchdog {
private RunningAppProvider runningAppProvider;
private boolean highlightsEnabled = true;
private boolean hadPreviousRunningBootApps = false;
private Timer timer;
@@ -157,17 +156,9 @@ public class SpringLiveHoverWatchdog {
publishLiveHints(docURI, ranges);
}
}
else if (this.hadPreviousRunningBootApps) {
// PT 156688501:
// Only clean up live hovers if there were running boot apps in the previous
// update, but not
// in the current one.
// This is to avoid unnecessary publishing of live hovers when there have been
// no running apps
// at all between consecutive updates.
else {
cleanupLiveHints(docURI);
}
this.hadPreviousRunningBootApps = hasCurrentRunningBootApps;
} catch (Exception e) {
logger.error("", e);
}