Spring/spring-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PT 159667257 - Re-introduce hack to bypass LSP4E completion sorting

Browse Source
This commit is contained in:
nsingh@pivotal.io
2019-10-23 10:10:27 -07:00
parent cca89dc294
commit a6c1d4efe8
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/completion/VscodeCompletionEngineAdapter.java
View File

@@ -31,6 +31,8 @@ import org.eclipse.lsp4j.TextEdit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.ide.vscode.commons.languageserver.completion.DocumentEdits.TextReplace;
import org.springframework.ide.vscode.commons.languageserver.util.LspClient;
import org.springframework.ide.vscode.commons.languageserver.util.LspClient.Client;
import org.springframework.ide.vscode.commons.languageserver.util.SimpleLanguageServer;
import org.springframework.ide.vscode.commons.languageserver.util.SimpleTextDocumentService;
import org.springframework.ide.vscode.commons.languageserver.util.SortKeys;
@@ -164,6 +166,12 @@ public class VscodeCompletionEngineAdapter implements VscodeCompletionEngine {
}
}
list.setItems(items);
//This is a hack. It bypasses lsp4e filtering / sorting because it
// it behaves totally bonkers. See: https://bugs.eclipse.org/bugs/show_bug.cgi?id=535823
// See also https://www.pivotaltracker.com/story/show/159667257
if (LspClient.currentClient()==Client.ECLIPSE) {
list.setIsIncomplete(true);
}
return list;
})
.doOnNext(x -> log.info("Got {} completions", x.getItems().size()))