Spring/spring-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

added timeout for hover computation inside of language server

Browse Source
This commit is contained in:
Martin Lippert
2021-03-02 12:14:58 +01:00
parent 28cb5f0761
commit aaf16eabb2
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/util/SimpleTextDocumentService.java
View File

@@ -17,6 +17,7 @@ import java.util.concurrent.CancellationException;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.TimeUnit;
import java.util.function.Consumer;
import java.util.stream.Collectors;
@@ -287,17 +288,17 @@ public class SimpleTextDocumentService implements TextDocumentService, DocumentE
public CompletableFuture<Hover> hover(HoverParams hoverParams) {
log.debug("hover requested for {}", hoverParams.getPosition());
return CompletableFutures.computeAsync(cancelToken -> {
CompletableFuture<Hover> result = CompletableFutures.computeAsync(cancelToken -> {
return computeHover(cancelToken, hoverParams);
});
// TODO: timeout still necessary ?????
// long timeout = props.getHoverTimeout();
// return timeout <= 0 ? async.invoke(() -> computeHover(hoverParams)) : async.invoke(Duration.ofMillis(timeout), () -> computeHover(hoverParams), Mono.fromRunnable(() -> {
// log.error("Hover Request handler timed out after {} ms.", timeout);
// }));
long timeout = props.getHoverTimeout();
if (timeout <= 0) {
return result;
}
else {
return result.completeOnTimeout(NO_HOVER, timeout, TimeUnit.MILLISECONDS);
}
}
private Hover computeHover(CancelChecker cancelToken, HoverParams hoverParams) {