Spring/spring-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

textDocument/definition should not send 'null' result

Browse Source 
See: https://github.com/spring-projects/sts4/issues/309
This commit is contained in:
Kris De Volder
2019-06-24 11:11:01 -07:00
parent 3a992f43cf
commit cd873229b6
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/util/SimpleTextDocumentService.java
View File

@@ -352,7 +352,11 @@ public class SimpleTextDocumentService implements TextDocumentService, DocumentE
if (h != null) {
return async.invoke(() -> {
List<Location> locations = h.handle(position);
return Either.<List<? extends Location>, List<? extends LocationLink>>forLeft(locations);
if (locations==null) {
// vscode client does not like to recieve null result. See: https://github.com/spring-projects/sts4/issues/309
locations = ImmutableList.of();
}
return Either.forLeft(locations);
});
}
return CompletableFuture.completedFuture(Either.forLeft(ImmutableList.of()));