Spring/spring-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Further implementation of metrics in live hovers

Browse Source 
Live hovers now show basic metrics
This commit is contained in:
Nieraj Singh
2020-11-05 16:23:45 -08:00
committed by BoykoAlex
parent ca72948de8
commit e919823112
2 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/livehover/v2/SpringProcessLiveDataExtractorOverJMX.java
View File

@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2019 Pivotal, Inc.
* Copyright (c) 2019, 2020 Pivotal, Inc.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
@@ -134,9 +134,18 @@ public class SpringProcessLiveDataExtractorOverJMX {
}
tags.add("uri:" + rm.getSplitPath()[0]);
if (!rm.getRequestMethods().isEmpty()) {
tags.add("methods:" + String.join(",", rm.getRequestMethods()));
tags.add("method:" + String.join(",", rm.getRequestMethods()));
}
Object metricsData = getActuatorDataFromOperation(connection, getObjectName(domain, "type=Endpoint,name=Metrics"), "metric", "http.server.requests", tags);
Object[] params = new Object[] {"http.server.requests", tags};
String[] signature = new String[] {String.class.getName(), List.class.getName()};
Object metricsData = getActuatorDataFromOperation(connection,
getObjectName(domain, "type=Endpoint,name=Metrics"),
"metric",
params,
signature);
if (metricsData instanceof String) {
return RequestMappingMetrics.parse((String) metricsData);
} else {
@@ -410,10 +419,10 @@ public class SpringProcessLiveDataExtractorOverJMX {
return null;
}
private Object getActuatorDataFromOperation(MBeanServerConnection connection, ObjectName objectName, String operation, Object... parameters) throws Exception {
private Object getActuatorDataFromOperation(MBeanServerConnection connection, ObjectName objectName, String operation, Object[] parameters, String[] tags) throws Exception {
if (objectName != null) {
try {
return connection.invoke(objectName, operation, parameters, null);
return connection.invoke(objectName, operation, parameters, tags);
}
catch (InstanceNotFoundException|IOException e) {
return null;

2
headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/requestmapping/RequestMappingHoverProvider.java
View File

@@ -281,7 +281,7 @@ public class RequestMappingHoverProvider implements HoverProvider {
RequestMappingMetrics metrics = liveData.getLiveMterics().getRequestMappingMetrics(requestMapping);
if (metrics != null) {
Renderable metricsRenderable = Renderables.bold("Count: " + metrics.getCallsCount() + " Total Time: " + metrics.getTotalTime());
Renderable metricsRenderable = Renderables.concat(Renderables.bold("Count: " + metrics.getCallsCount() + ", Total Time: " + metrics.getTotalTime()), Renderables.text("\n\n"));
urlRenderables = Renderables.concat(urlRenderables, Renderables.text("\n\n"), metricsRenderable);
}