Spring/spring-vault
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polishing.

Browse Source 
Remove final keyword from local variables. Extract renewal body creation to method. Add author tag.

Original pull request: gh-282.
See gh-262.
This commit is contained in:
Mark Paluch
2018-08-27 15:53:10 +02:00
parent 94153a5fcb
commit 1fde90afca
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
spring-vault-core/src/main/java/org/springframework/vault/core/lease/SecretLeaseContainer.java
View File

@@ -113,6 +113,7 @@ import org.springframework.web.client.HttpStatusCodeException;
*
* @author Mark Paluch
* @author Steven Swor
* @author Erik Lindblom
* @see RequestedSecret
* @see SecretLeaseEventPublisher
* @see Lease
@@ -593,12 +594,8 @@ public class SecretLeaseContainer extends SecretLeaseEventPublisher implements
@SuppressWarnings("unchecked")
private Lease renew(Lease lease) {
final Map<String, String> leaseRenewalData = new HashMap<>();
leaseRenewalData.put("lease_id", lease.getLeaseId());
leaseRenewalData.put("increment", Long.toString(lease.getLeaseDuration().getSeconds()));
HttpEntity<Object> leaseRenewalEntity = new HttpEntity<>(leaseRenewalData);
HttpEntity<Object> leaseRenewalEntity = getLeaseRenewalBody(lease);
ResponseEntity<Map<String, Object>> entity = operations
.doWithSession(restOperations -> (ResponseEntity) restOperations
@@ -616,6 +613,16 @@ public class SecretLeaseContainer extends SecretLeaseEventPublisher implements
renewable);
}
private static HttpEntity<Object> getLeaseRenewalBody(Lease lease) {
Map<String, String> leaseRenewalData = new HashMap<>();
leaseRenewalData.put("lease_id", lease.getLeaseId());
leaseRenewalData.put("increment",
Long.toString(lease.getLeaseDuration().getSeconds()));
return new HttpEntity<>(leaseRenewalData);
}
/**
* Hook method called when a {@link Lease} expires. The default implementation is to
* notify {@link LeaseListener}. Implementations can override this method in