Spring/spring-webflow
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Ensure saveState() is always called

Browse Source 
Update JsfView to ensure that saveState() called when processing
events. This is required to ensure that the Mojarra StateContext
will unsubscribe listeners from the UIViewRoot.

Issue: SWF-1577
This commit is contained in:
Phillip Webb
2013-01-30 13:56:24 -08:00
parent e23e427875
commit 0d17de3aad
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spring-faces/src/main/java/org/springframework/faces/webflow/JsfView.java
View File

@@ -85,11 +85,6 @@ public class JsfView implements View {
try {
logger.debug("Asking faces lifecycle to render");
this.facesLifecycle.render(facesContext);
// Ensure serialized view state is always updated even if JSF didn't call StateManager.writeState().
if (this.requestContext.getExternalContext().isAjaxRequest()) {
saveState();
}
} finally {
logger.debug("View rendering complete");
facesContext.responseComplete();
@@ -111,7 +106,10 @@ public class JsfView implements View {
*/
public void processUserEvent() {
FacesContext facesContext = FlowFacesContext.getCurrentInstance();
facesContext.setViewRoot(this.viewRoot);
// Ensure serialized view state is always updated even if JSF didn't call StateManager.writeState(). SWF-1577
saveState();
// Must respect these flags in case user set them during RESTORE_VIEW phase
if (!facesContext.getRenderResponse() && !facesContext.getResponseComplete()) {
this.facesLifecycle.execute(facesContext);