Spring/spring-webflow
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Move state saving to getUserEventState()

Browse Source 
Update JsfView so that state saving no longer occurs during
processUserEvent(). This is required to ensure that Mojarra's
StateContext.release(...) method is not called too early.

Prior to Mojarra 2.1.16 multiple calls to saveView had no side effects,
but the fix to JAVASERVERFACES-2609 changed this behavior.

In order to retain the fix for SWF-1577 the saveState() method is now
called from getUserEventState(). This should ensure that the
StateContext$AddRemoveListerner is still removed, even when WebFlow
bypasses the usual state saving for certain flow redirects.

Issue: SWF-1631
This commit is contained in:
Phillip Webb
2014-05-22 11:39:19 +01:00
committed by Rossen Stoyanchev
parent bdd3b4afe4
commit 51537e8c06
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
spring-faces/src/main/java/org/springframework/faces/webflow/JsfView.java
View File

@@ -106,10 +106,6 @@ public class JsfView implements View {
*/
public void processUserEvent() {
FacesContext facesContext = FlowFacesContext.getCurrentInstance();
// Ensure serialized view state is always updated even if JSF didn't call StateManager.writeState(). SWF-1577
saveState();
// Must respect these flags in case user set them during RESTORE_VIEW phase
if (!facesContext.getRenderResponse() && !facesContext.getResponseComplete()) {
this.facesLifecycle.execute(facesContext);
@@ -127,8 +123,11 @@ public class JsfView implements View {
}
public Serializable getUserEventState() {
// Set the temporary UIViewRoot state so that it will be available across the redirect (see comments in render()
// method)
// Set the temporary UIViewRoot state so that it will be available across the redirect (see comments in render() method)
// Ensure serialized view state is always updated even if JSF didn't call StateManager.writeState(). SWF-1577
saveState();
return new ViewRootHolder(getViewRoot());
}