Spring/spring-webflow
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Do not set accessDecisionManager property with default value. Otherwise the first matching type (any or all) will be applied to all subsequent access decisions.

Browse Source
This commit is contained in:
Scott Andrews
2008-04-07 19:39:29 +00:00
parent 49f735c797
commit 70857faa46
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
spring-webflow/src/main/java/org/springframework/webflow/security/SecurityFlowExecutionListener.java
View File

@@ -69,7 +69,9 @@ public class SecurityFlowExecutionListener extends FlowExecutionListenerAdapter
public void decide(SecurityRule rule, Object object) {
Authentication authentication = SecurityContextHolder.getContext().getAuthentication();
ConfigAttributeDefinition config = new ConfigAttributeDefinition(getConfigAttributes(rule));
if (accessDecisionManager == null) {
if (accessDecisionManager != null) {
accessDecisionManager.decide(authentication, object, config);
} else {
AbstractAccessDecisionManager abstractAccessDecisionManager;
List voters = new ArrayList();
voters.add(new RoleVoter());
@@ -81,9 +83,8 @@ public class SecurityFlowExecutionListener extends FlowExecutionListenerAdapter
throw new IllegalStateException("Unknown SecurityRule match type: " + rule.getComparisonType());
}
abstractAccessDecisionManager.setDecisionVoters(voters);
accessDecisionManager = abstractAccessDecisionManager;
abstractAccessDecisionManager.decide(authentication, object, config);
}
accessDecisionManager.decide(authentication, object, config);
}
/**