Spring/spring-webflow
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polishing: lazy init of FlowExecutionContinuationGroup to avoid calling conversation.lock/unlock from the FlowExecutionRepository.

Browse Source 
The conversation.lock/unlock methods are now only called from ConversationBackedFlowExecutionLock, which in turn is only called from the flow executor.
This commit is contained in:
Erwin Vervaet
2007-03-29 11:12:20 +00:00
parent c8af02186c
commit b886482da5
1 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
spring-webflow/src/main/java/org/springframework/webflow/execution/repository/continuation/ContinuationFlowExecutionRepository.java
View File

@@ -183,18 +183,6 @@ public class ContinuationFlowExecutionRepository extends AbstractConversationFlo
putConversationScope(key, flowExecution.getConversationScope());
}
protected void onBegin(Conversation conversation) {
// setup a new continuation group for the conversation
FlowExecutionContinuationGroup continuationGroup = new FlowExecutionContinuationGroup(maxContinuations);
conversation.lock();
try {
conversation.putAttribute(CONTINUATION_GROUP_ATTRIBUTE, continuationGroup);
}
finally {
conversation.unlock();
}
}
protected Serializable generateContinuationId(FlowExecution flowExecution) {
return continuationIdGenerator.generateUid();
}
@@ -210,8 +198,17 @@ public class ContinuationFlowExecutionRepository extends AbstractConversationFlo
* @return the continuation group
*/
FlowExecutionContinuationGroup getContinuationGroup(FlowExecutionKey key) {
Conversation conversation = getConversation(key);
FlowExecutionContinuationGroup group =
(FlowExecutionContinuationGroup)getConversation(key).getAttribute(CONTINUATION_GROUP_ATTRIBUTE);
(FlowExecutionContinuationGroup)conversation.getAttribute(CONTINUATION_GROUP_ATTRIBUTE);
if (group == null) {
// setup a new continuation group for the conversation
// no need to synchronize here since this code will only be executed
// during the launch of a new flow execution, at which time the
// key has not yet been communicated to any other threads
group = new FlowExecutionContinuationGroup(maxContinuations);
conversation.putAttribute(CONTINUATION_GROUP_ATTRIBUTE, group);
}
return group;
}