Spring/spring-webflow
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

patched to load java-based flow definition eagerly to reduce class loading overhead

Browse Source
This commit is contained in:
Keith Donald
2007-11-16 18:13:41 +00:00
parent 012180eec4
commit e3ec26007e
1 changed files with 19 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

67
spring-webflow/src/main/java/org/springframework/webflow/config/FlowRegistryFactoryBean.java
View File

@@ -41,7 +41,7 @@ class FlowRegistryFactoryBean implements FactoryBean, ResourceLoaderAware, BeanF
/**
* The definition registry produced by this factory bean.
*/
private FlowDefinitionRegistry flowRegistry;
private FlowDefinitionRegistryImpl flowRegistry;
/**
* Flow definitions defined in external files that should be registered in the registry produced by this factory
@@ -129,8 +129,8 @@ class FlowRegistryFactoryBean implements FactoryBean, ResourceLoaderAware, BeanF
private void registerFlowBuilders() {
if (flowBuilders != null) {
for (int i = 0; i < flowBuilders.length; i++) {
FlowBuilderInfo builder = flowBuilders[i];
flowRegistry.registerFlowDefinition(createFlowDefinitionHolder(builder));
FlowBuilderInfo builderInfo = flowBuilders[i];
flowRegistry.registerFlowDefinition(buildFlowDefinition(builderInfo));
}
}
}
@@ -184,12 +184,22 @@ class FlowRegistryFactoryBean implements FactoryBean, ResourceLoaderAware, BeanF
}
}
private FlowDefinitionHolder createFlowDefinitionHolder(FlowBuilderInfo builder) {
ClassLoader classLoader = ClassUtils.getDefaultClassLoader();
AttributeMap flowAttributes = getFlowAttributes(builder.getAttributes());
FlowBuilderContext builderContext = new FlowBuilderContextImpl(builder.getId(), flowAttributes, flowRegistry,
flowBuilderServices);
return new FlowBuilderCreatingFlowDefinitionHolder(builder.getClassName(), classLoader, builderContext);
private FlowDefinition buildFlowDefinition(FlowBuilderInfo builderInfo) {
try {
Class flowBuilderClass = ClassUtils.forName(builderInfo.getClassName());
FlowBuilder builder = (FlowBuilder) flowBuilderClass.newInstance();
AttributeMap flowAttributes = getFlowAttributes(builderInfo.getAttributes());
FlowBuilderContext builderContext = new FlowBuilderContextImpl(builderInfo.getId(), flowAttributes,
flowRegistry, flowBuilderServices);
FlowAssembler assembler = new FlowAssembler(builder, builderContext);
return assembler.assembleFlow();
} catch (ClassNotFoundException e) {
throw new FlowDefinitionConstructionException(builderInfo.getId(), e);
} catch (InstantiationException e) {
throw new FlowDefinitionConstructionException(builderInfo.getId(), e);
} catch (IllegalAccessException e) {
throw new FlowDefinitionConstructionException(builderInfo.getId(), e);
}
}
private void initFlowBuilderServices() {
@@ -197,43 +207,4 @@ class FlowRegistryFactoryBean implements FactoryBean, ResourceLoaderAware, BeanF
flowBuilderServices.setResourceLoader(resourceLoader);
flowBuilderServices.setBeanFactory(beanFactory);
}
class FlowBuilderCreatingFlowDefinitionHolder implements FlowDefinitionHolder {
private String flowBuilderClassName;
private ClassLoader classLoader;
private FlowBuilderContext builderContext;
public FlowBuilderCreatingFlowDefinitionHolder(String flowBuilderClassName, ClassLoader classLoader,
FlowBuilderContext builderContext) {
this.flowBuilderClassName = flowBuilderClassName;
this.classLoader = classLoader;
this.builderContext = builderContext;
}
public String getFlowDefinitionId() {
return builderContext.getFlowId();
}
public FlowDefinition getFlowDefinition() throws FlowDefinitionConstructionException {
try {
Class flowBuilderClass = classLoader.loadClass(flowBuilderClassName);
FlowBuilder builder = (FlowBuilder) flowBuilderClass.newInstance();
FlowAssembler assembler = new FlowAssembler(builder, builderContext);
return assembler.assembleFlow();
} catch (ClassNotFoundException e) {
throw new FlowDefinitionConstructionException(getFlowDefinitionId(), e);
} catch (InstantiationException e) {
throw new FlowDefinitionConstructionException(getFlowDefinitionId(), e);
} catch (IllegalAccessException e) {
throw new FlowDefinitionConstructionException(getFlowDefinitionId(), e);
}
}
public void refresh() throws FlowDefinitionConstructionException {
}
}
}