Mark private classes final

See gh-1479
This commit is contained in:
Stéphane Nicoll
2025-03-07 13:04:48 +01:00
parent 360f52379b
commit 00e1e68062
48 changed files with 70 additions and 69 deletions

View File

@@ -852,7 +852,8 @@ public class WebServiceTemplate extends WebServiceAccessor implements WebService
* Adapter to enable use of a WebServiceMessageCallback inside a
* WebServiceMessageExtractor.
*/
private static class WebServiceMessageCallbackMessageExtractor implements WebServiceMessageExtractor<Boolean> {
private static final class WebServiceMessageCallbackMessageExtractor
implements WebServiceMessageExtractor<Boolean> {
private final WebServiceMessageCallback callback;
@@ -869,7 +870,7 @@ public class WebServiceTemplate extends WebServiceAccessor implements WebService
}
/** Adapter to enable use of a SourceExtractor inside a WebServiceMessageExtractor. */
private static class SourceExtractorMessageExtractor<T> implements WebServiceMessageExtractor<T> {
private static final class SourceExtractorMessageExtractor<T> implements WebServiceMessageExtractor<T> {
private final SourceExtractor<T> sourceExtractor;

View File

@@ -69,7 +69,7 @@ public class DelegatingWsConfiguration extends WsConfigurationSupport {
this.configurers.addReturnValueHandlers(returnValueHandlers);
}
private static class WsConfigurers implements WsConfigurer {
private static final class WsConfigurers implements WsConfigurer {
private final Supplier<Stream<WsConfigurer>> delegates;

View File

@@ -65,7 +65,7 @@ public abstract class AbstractMimeMessage implements MimeMessage {
* @author Arjen Poutsma
* @since 1.0.0
*/
private static class InputStreamSourceDataSource implements DataSource {
private static final class InputStreamSourceDataSource implements DataSource {
private final InputStreamSource inputStreamSource;

View File

@@ -151,7 +151,7 @@ public abstract class AbstractStaxEventPayloadEndpoint extends AbstractStaxPaylo
* {@code WebServiceMessage} as soon as any method is called, thus lazily creating the
* response.
*/
private class ResponseCreatingEventWriter implements XMLEventWriter {
private final class ResponseCreatingEventWriter implements XMLEventWriter {
private XMLEventWriter eventWriter;

View File

@@ -126,7 +126,7 @@ public abstract class AbstractStaxStreamPayloadEndpoint extends AbstractStaxPayl
* {@code WebServiceMessage} as soon as any method is called, thus lazily creating the
* response.
*/
private class ResponseCreatingStreamWriter implements XMLStreamWriter {
private final class ResponseCreatingStreamWriter implements XMLStreamWriter {
private MessageContext messageContext;

View File

@@ -116,7 +116,7 @@ public abstract class AbstractXomPayloadEndpoint extends TransformerObjectSuppor
*/
protected abstract Element invokeInternal(Element requestElement) throws Exception;
private static class XomSourceCallback implements TraxUtils.SourceCallback {
private static final class XomSourceCallback implements TraxUtils.SourceCallback {
private Element element;
@@ -206,7 +206,7 @@ public abstract class AbstractXomPayloadEndpoint extends TransformerObjectSuppor
}
@SuppressWarnings("serial")
private static class XomParsingException extends NestedRuntimeException {
private static final class XomParsingException extends NestedRuntimeException {
private XomParsingException(ParsingException ex) {
super(ex.getMessage(), ex);
@@ -214,7 +214,7 @@ public abstract class AbstractXomPayloadEndpoint extends TransformerObjectSuppor
}
private static class StaxStreamConverter {
private static final class StaxStreamConverter {
private static Document convert(XMLStreamReader streamReader) throws XMLStreamException {
NodeFactory nodeFactory = new NodeFactory();

View File

@@ -129,7 +129,7 @@ public class SourcePayloadMethodProcessor extends AbstractPayloadSourceMethodPro
}
/** Inner class to avoid a static JAXP 1.4 dependency. */
private static class Jaxp14StaxHandler {
private static final class Jaxp14StaxHandler {
private static boolean isStaxSource(Class<?> clazz) {
return StAXSource.class.isAssignableFrom(clazz);
@@ -141,7 +141,7 @@ public class SourcePayloadMethodProcessor extends AbstractPayloadSourceMethodPro
}
private static class SystemIdStreamReaderDelegate extends StreamReaderDelegate {
private static final class SystemIdStreamReaderDelegate extends StreamReaderDelegate {
private final String systemId;

View File

@@ -233,7 +233,7 @@ public abstract class AbstractJaxb2PayloadMethodProcessor extends AbstractPayloa
// Callbacks
private class Jaxb2SourceCallback implements TraxUtils.SourceCallback {
private final class Jaxb2SourceCallback implements TraxUtils.SourceCallback {
private final Unmarshaller unmarshaller;
@@ -301,7 +301,7 @@ public abstract class AbstractJaxb2PayloadMethodProcessor extends AbstractPayloa
}
private class JaxbElementSourceCallback<T> implements TraxUtils.SourceCallback {
private final class JaxbElementSourceCallback<T> implements TraxUtils.SourceCallback {
private final Unmarshaller unmarshaller;
@@ -351,7 +351,7 @@ public abstract class AbstractJaxb2PayloadMethodProcessor extends AbstractPayloa
}
private class Jaxb2ResultCallback implements TraxUtils.ResultCallback {
private final class Jaxb2ResultCallback implements TraxUtils.ResultCallback {
private final Marshaller marshaller;
@@ -399,7 +399,7 @@ public abstract class AbstractJaxb2PayloadMethodProcessor extends AbstractPayloa
}
private class JaxbStreamingPayload implements StreamingPayload {
private final class JaxbStreamingPayload implements StreamingPayload {
private final Object jaxbElement;

View File

@@ -89,7 +89,7 @@ public abstract class PayloadRootUtils {
}
}
private static class PayloadRootSourceCallback implements TraxUtils.SourceCallback {
private static final class PayloadRootSourceCallback implements TraxUtils.SourceCallback {
private QName result;

View File

@@ -71,7 +71,7 @@ class SaajSoapFaultDetail extends SaajSoapElement<SOAPFaultElement> implements S
return (Detail) getSaajElement();
}
private static class SaajSoapFaultDetailElementIterator implements Iterator<SoapFaultDetailElement> {
private static final class SaajSoapFaultDetailElementIterator implements Iterator<SoapFaultDetailElement> {
private final Iterator<DetailEntry> iterator;

View File

@@ -364,7 +364,7 @@ public class SaajSoapMessage extends AbstractSoapMessage {
return builder.toString();
}
private static class SaajAttachmentIterator implements Iterator<Attachment> {
private static final class SaajAttachmentIterator implements Iterator<Attachment> {
private final Iterator<AttachmentPart> saajIterator;

View File

@@ -86,7 +86,7 @@ public abstract class MarshallingUtils {
}
}
private static class MimeMessageContainer implements MimeContainer {
private static final class MimeMessageContainer implements MimeContainer {
private final MimeMessage mimeMessage;

View File

@@ -67,7 +67,7 @@ public abstract class AbstractReceiverConnection extends AbstractWebServiceConne
protected abstract OutputStream getResponseOutputStream() throws IOException;
/** Implementation of {@code TransportInputStream} for receiving-side connections. */
private class RequestTransportInputStream extends TransportInputStream {
private final class RequestTransportInputStream extends TransportInputStream {
@Override
protected InputStream createInputStream() throws IOException {
@@ -87,7 +87,7 @@ public abstract class AbstractReceiverConnection extends AbstractWebServiceConne
}
/** Implementation of {@code TransportOutputStream} for sending-side connections. */
private class ResponseTransportOutputStream extends TransportOutputStream {
private final class ResponseTransportOutputStream extends TransportOutputStream {
@Override
public void addHeader(String name, String value) throws IOException {

View File

@@ -46,7 +46,7 @@ public abstract class TransportContextHolder {
return transportContextHolder.get();
}
private static class TransportThreadLocal extends ThreadLocal<TransportContext> {
private static final class TransportThreadLocal extends ThreadLocal<TransportContext> {
public String toString() {
return "Transport State";

View File

@@ -171,7 +171,7 @@ public class MockWebServiceMessage implements FaultAwareWebServiceMessage {
return builder.toString();
}
private class StringBufferWriter extends Writer {
private final class StringBufferWriter extends Writer {
private StringBufferWriter() {
super(MockWebServiceMessage.this.content);

View File

@@ -288,7 +288,7 @@ public abstract class AbstractSoap11WebServiceTemplateIntegrationTest {
/** Servlet that returns and error message for a given status code. */
@SuppressWarnings("serial")
private static class ErrorServlet extends HttpServlet {
private static final class ErrorServlet extends HttpServlet {
private int sc;

View File

@@ -97,7 +97,7 @@ public class DefaultWsConfigurationTest {
}
@Endpoint
private static class TestEndpoint {
private static final class TestEndpoint {
@SoapAction("handle")
public void handle() {

View File

@@ -258,7 +258,7 @@ public class MarshallingPayloadEndpointTest {
verify(this.factoryMock, unmarshaller, marshaller, request, response);
}
private static class SimpleMarshaller implements Marshaller, Unmarshaller {
static class SimpleMarshaller implements Marshaller, Unmarshaller {
@Override
public void marshal(Object graph, Result result) throws XmlMappingException {

View File

@@ -83,7 +83,7 @@ public class SaxPayloadEndpointTest extends AbstractPayloadEndpointTest {
};
}
private static class TestContentHandler extends DefaultHandler {
private static final class TestContentHandler extends DefaultHandler {
@Override
public void endElement(String uri, String localName, String qName) {

View File

@@ -224,11 +224,11 @@ public class GenericMarshallingMethodEndpointAdapterTest {
return s;
}
private static class MyType {
private static final class MyType {
}
private static class MyGenericType<T> {
private static final class MyGenericType<T> {
}

View File

@@ -208,7 +208,7 @@ public class MarshallingMethodEndpointAdapterTest {
return s;
}
private static class MyType {
private static final class MyType {
}

View File

@@ -192,7 +192,7 @@ public class EndpointMappingTest {
assertThat(MyEndpoint.constructorCount).isEqualTo(2);
}
private static class MyEndpoint {
private static final class MyEndpoint {
private static int constructorCount;
@@ -202,7 +202,7 @@ public class EndpointMappingTest {
}
private static class MySmartEndpointInterceptor extends DelegatingSmartEndpointInterceptor {
private static final class MySmartEndpointInterceptor extends DelegatingSmartEndpointInterceptor {
private MySmartEndpointInterceptor() {
super(new EndpointInterceptorAdapter());

View File

@@ -102,7 +102,7 @@ public class MapBasedSoapEndpointMappingTest {
assertThat(mapping.getEndpointInternal(null)).isNull();
}
private static class MyMapBasedEndpointMapping extends AbstractMapBasedEndpointMapping {
private static final class MyMapBasedEndpointMapping extends AbstractMapBasedEndpointMapping {
private String key;

View File

@@ -69,7 +69,7 @@ public class SimpleMethodEndpointMappingTest {
assertThat(this.mapping.getLookupKeyForMessage(messageContext)).isEqualTo("MyRequest");
}
private static class MyBean {
private static final class MyBean {
public void prefixMyRequestSuffix() {

View File

@@ -100,7 +100,7 @@ public class AnnotationActionMethodEndpointMappingTest {
@Endpoint
@Address("mailto:joe@fabrikam123.example")
private static class MyEndpoint {
private static final class MyEndpoint {
@Action("http://fabrikam123.example/mail/Delete")
public void doIt() {
@@ -109,7 +109,7 @@ public class AnnotationActionMethodEndpointMappingTest {
}
private static class MyInterceptor extends DelegatingSmartEndpointInterceptor {
private static final class MyInterceptor extends DelegatingSmartEndpointInterceptor {
public MyInterceptor() {
super(new PayloadLoggingInterceptor());
@@ -117,7 +117,7 @@ public class AnnotationActionMethodEndpointMappingTest {
}
private static class MySmartInterceptor extends DelegatingSmartEndpointInterceptor {
private static final class MySmartInterceptor extends DelegatingSmartEndpointInterceptor {
public MySmartInterceptor() {
super(new PayloadLoggingInterceptor());

View File

@@ -92,11 +92,11 @@ public class SimpleActionEndpointMappingTest extends AbstractWsAddressingTest {
assertThat(endpoint).isNull();
}
private static class Endpoint1 {
private static final class Endpoint1 {
}
private static class Endpoint2 {
private static final class Endpoint2 {
}

View File

@@ -143,7 +143,7 @@ public class FaultCreatingValidatingMarshallingPayloadEndpointTest {
assertThat(response.getSOAPBody().hasFault()).isFalse();
}
private static class PersonValidator implements Validator {
private static final class PersonValidator implements Validator {
@Override
public boolean supports(Class<?> clazz) {
@@ -166,7 +166,7 @@ public class FaultCreatingValidatingMarshallingPayloadEndpointTest {
}
private static class Person {
private static final class Person {
private String name;
@@ -200,7 +200,7 @@ public class FaultCreatingValidatingMarshallingPayloadEndpointTest {
}
private static class PersonMarshaller implements Unmarshaller, Marshaller {
private static final class PersonMarshaller implements Unmarshaller, Marshaller {
private final Person person;

View File

@@ -128,7 +128,7 @@ public class SoapActionAnnotationMethodEndpointMappingTest {
}
@Endpoint
private static class MyEndpoint {
private static final class MyEndpoint {
@SoapAction("http://springframework.org/spring-ws/SoapAction")
public void doIt() {

View File

@@ -105,11 +105,11 @@ public class DefaultStrategiesHelperTest {
}
private static class StrategyImpl implements Strategy {
private static final class StrategyImpl implements Strategy {
}
private static class ContextAwareStrategyImpl implements Strategy, ApplicationContextAware {
private static final class ContextAwareStrategyImpl implements Strategy, ApplicationContextAware {
private ApplicationContext applicationContext;

View File

@@ -109,7 +109,7 @@ public class MessageDispatcherServletTest {
XmlAssert.assertThat(result).and(expected).ignoreWhitespace().areIdentical();
}
private static class DetectWebApplicationContext extends StaticWebApplicationContext {
private static final class DetectWebApplicationContext extends StaticWebApplicationContext {
@Override
public void refresh() throws BeansException, IllegalStateException {
@@ -123,7 +123,7 @@ public class MessageDispatcherServletTest {
}
private static class WsdlDefinitionWebApplicationContext extends StaticWebApplicationContext {
private static final class WsdlDefinitionWebApplicationContext extends StaticWebApplicationContext {
@Override
public void refresh() throws BeansException, IllegalStateException {

View File

@@ -122,7 +122,7 @@ public class WebServiceMessageReceiverObjectSupportTest {
verify(this.connectionMock).receive(this.messageFactory);
}
private static class MyReceiverSupport extends WebServiceMessageReceiverObjectSupport {
private static final class MyReceiverSupport extends WebServiceMessageReceiverObjectSupport {
}

View File

@@ -87,7 +87,7 @@ public abstract class Wss4jMessageInterceptorSamlTest extends Wss4jTest {
return new SamlCallbackHandler(crypto, userCert);
}
private static class SamlCallbackHandler implements CallbackHandler {
private static final class SamlCallbackHandler implements CallbackHandler {
private Crypto crypto;

View File

@@ -219,7 +219,7 @@ public class MailMessageReceiver extends AbstractAsyncStandaloneMessageReceiver
MailTransportUtils.closeService(this.store);
}
private class MonitoringRunnable implements SchedulingAwareRunnable {
private final class MonitoringRunnable implements SchedulingAwareRunnable {
@Override
public void run() {
@@ -261,7 +261,7 @@ public class MailMessageReceiver extends AbstractAsyncStandaloneMessageReceiver
}
private class MessageHandler implements SchedulingAwareRunnable {
private final class MessageHandler implements SchedulingAwareRunnable {
private final Message message;

View File

@@ -229,7 +229,7 @@ public class MailReceiverConnection extends AbstractReceiverConnection {
}
}
private static class ByteArrayDataSource implements DataSource {
private static final class ByteArrayDataSource implements DataSource {
private byte[] data;

View File

@@ -307,7 +307,7 @@ public class MailSenderConnection extends AbstractSenderConnection {
MailTransportUtils.closeService(this.store);
}
private static class ByteArrayDataSource implements DataSource {
private static final class ByteArrayDataSource implements DataSource {
private byte[] data;

View File

@@ -106,7 +106,7 @@ public class XmppMessageReceiver extends AbstractStandaloneMessageReceiver {
}
}
private class WebServicePacketListener implements StanzaListener {
private final class WebServicePacketListener implements StanzaListener {
@Override
public void processStanza(Stanza packet) {

View File

@@ -194,7 +194,7 @@ public abstract class ResponseCreators {
/**
* Adapts a {@link WebServiceMessageCreator} to the {@link ResponseCreator} contract.
*/
private static class WebServiceMessageCreatorAdapter implements ResponseCreator {
private static final class WebServiceMessageCreatorAdapter implements ResponseCreator {
private final WebServiceMessageCreator adaptee;

View File

@@ -193,7 +193,7 @@ public class MockWebServiceClient {
// ResponseActions
private static class MockWebServiceClientResponseActions implements ResponseActions {
private static final class MockWebServiceClientResponseActions implements ResponseActions {
private final MessageContext messageContext;

View File

@@ -90,7 +90,7 @@ public abstract class RequestCreators {
/**
* Adapts a {@link WebServiceMessageCreator} to the {@link RequestCreator} contract.
*/
private static class WebServiceMessageCreatorAdapter implements RequestCreator {
private static final class WebServiceMessageCreatorAdapter implements RequestCreator {
private final WebServiceMessageCreator adaptee;

View File

@@ -420,7 +420,7 @@ public class MockWebServiceServerTest {
}
@XmlRootElement(name = "EnvelopeMatcherRequest")
private static class EnvelopeMatcherRequest {
private static final class EnvelopeMatcherRequest {
private String myData;
@@ -435,7 +435,7 @@ public class MockWebServiceServerTest {
}
@XmlRootElement(name = "EnvelopeMatcherResponse")
private static class EnvelopeMatcherResponse {
private static final class EnvelopeMatcherResponse {
private String myData;

View File

@@ -48,7 +48,7 @@ abstract class Jaxp13ValidatorFactory {
}
}
private static class Jaxp13Validator implements XmlValidator {
private static final class Jaxp13Validator implements XmlValidator {
private Schema schema;
@@ -82,7 +82,7 @@ abstract class Jaxp13ValidatorFactory {
/**
* {@code ErrorHandler} implementation that stores errors and fatal errors in a list.
*/
private static class DefaultValidationErrorHandler implements ValidationErrorHandler {
private static final class DefaultValidationErrorHandler implements ValidationErrorHandler {
private List<SAXParseException> errors = new ArrayList<>();

View File

@@ -56,7 +56,7 @@ abstract class Jaxp15ValidatorFactory {
}
}
private static class Jaxp15Validator implements XmlValidator {
private static final class Jaxp15Validator implements XmlValidator {
private Schema schema;
@@ -111,7 +111,7 @@ abstract class Jaxp15ValidatorFactory {
/**
* {@code ErrorHandler} implementation that stores errors and fatal errors in a list.
*/
private static class DefaultValidationErrorHandler implements ValidationErrorHandler {
private static final class DefaultValidationErrorHandler implements ValidationErrorHandler {
private List<SAXParseException> errors = new ArrayList<>();

View File

@@ -60,7 +60,7 @@ public abstract class AbstractXPathTemplate extends TransformerObjectSupport imp
* Static inner class that adapts a {@link NodeCallbackHandler} to the interface of
* {@link NodeMapper}.
*/
private static class NodeCallbackHandlerNodeMapper implements NodeMapper<Object> {
private static final class NodeCallbackHandlerNodeMapper implements NodeMapper<Object> {
private final NodeCallbackHandler callbackHandler;

View File

@@ -75,7 +75,7 @@ abstract class JaxenXPathExpressionFactory {
}
/** Jaxen implementation of the {@code XPathExpression} interface. */
private static class JaxenXpathExpression implements XPathExpression {
private static final class JaxenXpathExpression implements XPathExpression {
private XPath xpath;

View File

@@ -90,7 +90,7 @@ abstract class Jaxp13XPathExpressionFactory {
}
/** JAXP 1.3 implementation of the {@code XPathExpression} interface. */
private static class Jaxp13XPathExpression implements XPathExpression {
private static final class Jaxp13XPathExpression implements XPathExpression {
private final javax.xml.xpath.XPathExpression xpathExpression;

View File

@@ -164,7 +164,7 @@ public class Jaxp13XPathTemplate extends AbstractXPathTemplate {
return this.xpathFactory.newXPath();
}
private static class EvaluationCallback implements TraxUtils.SourceCallback {
private static final class EvaluationCallback implements TraxUtils.SourceCallback {
private final XPath xpath;

View File

@@ -236,7 +236,7 @@ public class CommonsXsdSchemaCollection implements XsdSchemaCollection, Initiali
return builder.toString();
}
private class ClasspathUriResolver extends DefaultURIResolver {
private final class ClasspathUriResolver extends DefaultURIResolver {
@Override
public InputSource resolveEntity(String namespace, String schemaLocation, String baseUri) {

View File

@@ -56,7 +56,7 @@ public class XmlValidatorFactoryTest {
.createValidator(new ClassPathResource("schema.xsd", AbstractValidatorFactoryTest.class), "bla"));
}
private static class NonExistentResource extends AbstractResource {
private static final class NonExistentResource extends AbstractResource {
@Override
public Resource createRelative(String relativePath) throws IOException {