Apply connection timeout correctly

This commit updates HttpComponents5MessageSender to apply the
configured connection timeout. Previously, it was wrongly set as the
connection request timeout.

Closes gh-1436
This commit is contained in:
Corneil du Plessis
2024-11-05 09:55:05 +02:00
committed by Stéphane Nicoll
parent 2744867894
commit 3463205b8c

View File

@@ -200,6 +200,7 @@ public class HttpComponents5ClientFactory implements FactoryBean<CloseableHttpCl
}
@Override
@SuppressWarnings("deprecation")
public CloseableHttpClient getObject() throws Exception {
PoolingHttpClientConnectionManagerBuilder connectionManagerBuilder = PoolingHttpClientConnectionManagerBuilder
@@ -218,7 +219,7 @@ public class HttpComponents5ClientFactory implements FactoryBean<CloseableHttpCl
applyMaxConnectionsPerHost(this.connectionManager);
RequestConfig.Builder requestConfigBuilder = RequestConfig.custom() //
.setConnectionRequestTimeout(Timeout.of(this.connectionTimeout)) //
.setConnectTimeout(Timeout.of(this.connectionTimeout)) //
.setResponseTimeout(Timeout.of(this.readTimeout));
HttpClientBuilder httpClientBuilder = HttpClientBuilder.create() //