SpringCloud/spring-cloud-app-broker
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

URL Cleanup

Browse Source 
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).

# Fixed URLs

## Fixed But Review Recommended
These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended.

* [ ] http://myfiles/app.jar (UnknownHostException) with 1 occurrences migrated to:
  https://myfiles/app.jar ([https](https://myfiles/app.jar) result UnknownHostException).
* [ ] http://myfiles/app1.jar (UnknownHostException) with 5 occurrences migrated to:
  https://myfiles/app1.jar ([https](https://myfiles/app1.jar) result UnknownHostException).
* [ ] http://myfiles/app2.jar (UnknownHostException) with 5 occurrences migrated to:
  https://myfiles/app2.jar ([https](https://myfiles/app2.jar) result UnknownHostException).

## Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

* [ ] http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html with 1 occurrences migrated to:
  https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html ([https](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) result 200).
* [ ] http://contributor-covenant.org with 1 occurrences migrated to:
  https://contributor-covenant.org ([https](https://contributor-covenant.org) result 301).
* [ ] http://contributor-covenant.org/version/1/3/0/ with 1 occurrences migrated to:
  https://contributor-covenant.org/version/1/3/0/ ([https](https://contributor-covenant.org/version/1/3/0/) result 301).
* [ ] http://plugins.jetbrains.com/plugin/6546 with 1 occurrences migrated to:
  https://plugins.jetbrains.com/plugin/6546 ([https](https://plugins.jetbrains.com/plugin/6546) result 301).

# Ignored
These URLs were intentionally ignored.

* http://localhost with 9 occurrences
* http://localhost/v2 with 1 occurrences
* http://localhost/v3 with 1 occurrences
* http://localhost:8888 with 4 occurrences
This commit is contained in:
Spring Operator
2019-03-20 15:37:17 -05:00
committed by Roy Clarkson
parent 7fccaa697b
commit 4d874c77c1
8 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CODE_OF_CONDUCT.adoc
View File

@@ -24,4 +24,4 @@ Instances of abusive, harassing, or otherwise unacceptable behavior may be repor
All complaints will be reviewed and investigated and will result in a response that is deemed necessary and appropriate to the circumstances.
Maintainers are obligated to maintain confidentiality with regard to the reporter of an incident.
This Code of Conduct is adapted from the http://contributor-covenant.org[Contributor Covenant], version 1.3.0, available at http://contributor-covenant.org/version/1/3/0/[contributor-covenant.org/version/1/3/0/].
This Code of Conduct is adapted from the https://contributor-covenant.org[Contributor Covenant], version 1.3.0, available at https://contributor-covenant.org/version/1/3/0/[contributor-covenant.org/version/1/3/0/].

4
CONTRIBUTING.adoc
View File

@@ -28,7 +28,7 @@ added after the original pull request but before a merge.
`eclipse-code-formatter.xml` file from the
https://raw.githubusercontent.com/spring-cloud/spring-cloud-build/master/spring-cloud-dependencies-parent/eclipse-code-formatter.xml[Spring
Cloud Build] project. If using IntelliJ, you can use the
http://plugins.jetbrains.com/plugin/6546[Eclipse Code Formatter
https://plugins.jetbrains.com/plugin/6546[Eclipse Code Formatter
Plugin] to import the same file.
* Make sure all new `.java` files to have a simple Javadoc class comment with at least an
`@author` tag identifying you, and preferably at least a paragraph on what the class is
@@ -41,7 +41,7 @@ added after the original pull request but before a merge.
* A few unit tests would help a lot as well -- someone has to do it.
* If no-one else is using your branch, please rebase it against the current master (or
other target branch in the main project).
* When writing a commit message please follow http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html[these conventions],
* When writing a commit message please follow https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html[these conventions],
if you are fixing an existing issue please add `Fixes gh-XXXX` at the end of the commit
message (where XXXX is the issue number).

4
spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/deployer/BackingAppDeploymentServiceTest.java
View File

@@ -28,11 +28,11 @@ class BackingAppDeploymentServiceTest {
backingApps = BackingApplications.builder()
.backingApplication(BackingApplication.builder()
.name("testApp1")
.path("http://myfiles/app1.jar")
.path("https://myfiles/app1.jar")
.build())
.backingApplication(BackingApplication.builder()
.name("testApp2")
.path("http://myfiles/app2.jar")
.path("https://myfiles/app2.jar")
.build())
.build();
}

4
spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/manager/BackingAppManagementServiceTest.java
View File

@@ -63,11 +63,11 @@ class BackingAppManagementServiceTest {
this.backingApps = BackingApplications.builder()
.backingApplication(BackingApplication.builder()
.name("testApp1")
.path("http://myfiles/app1.jar")
.path("https://myfiles/app1.jar")
.build())
.backingApplication(BackingApplication.builder()
.name("testApp2")
.path("http://myfiles/app2.jar")
.path("https://myfiles/app2.jar")
.build())
.build();

4
spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentCreateServiceInstanceWorkflowTest.java
View File

@@ -87,12 +87,12 @@ class AppDeploymentCreateServiceInstanceWorkflowTest {
.backingApplication(BackingApplication
.builder()
.name("app1")
.path("http://myfiles/app1.jar")
.path("https://myfiles/app1.jar")
.build())
.backingApplication(BackingApplication
.builder()
.name("app2")
.path("http://myfiles/app2.jar")
.path("https://myfiles/app2.jar")
.build())
.build();

4
spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentDeleteServiceInstanceWorkflowTest.java
View File

@@ -74,12 +74,12 @@ class AppDeploymentDeleteServiceInstanceWorkflowTest {
.backingApplication(BackingApplication
.builder()
.name("app1")
.path("http://myfiles/app1.jar")
.path("https://myfiles/app1.jar")
.build())
.backingApplication(BackingApplication
.builder()
.name("app2")
.path("http://myfiles/app2.jar")
.path("https://myfiles/app2.jar")
.build())
.build();

2
spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentInstanceWorkflowTest.java
View File

@@ -38,7 +38,7 @@ class AppDeploymentInstanceWorkflowTest {
backingApps = BackingApplications.builder()
.backingApplication(BackingApplication.builder()
.name("app1")
.path("http://myfiles/app.jar")
.path("https://myfiles/app.jar")
.build())
.build();

4
spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentUpdateServiceInstanceWorkflowTest.java
View File

@@ -81,11 +81,11 @@ class AppDeploymentUpdateServiceInstanceWorkflowTest {
.builder()
.backingApplication(BackingApplication.builder()
.name("app1")
.path("http://myfiles/app1.jar")
.path("https://myfiles/app1.jar")
.build())
.backingApplication(BackingApplication.builder()
.name("app2")
.path("http://myfiles/app2.jar")
.path("https://myfiles/app2.jar")
.build())
.build();