SpringCloud/spring-cloud-build
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Parametrized suppressions

Browse Source
This commit is contained in:
Marcin Grzejszczak
2019-02-02 11:36:12 +01:00
parent 56150ea5ea
commit 6b947f96b8
3 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pom.xml
View File

@@ -66,6 +66,10 @@
<maven-checkstyle-plugin.failsOnError>false</maven-checkstyle-plugin.failsOnError>
<maven-checkstyle-plugin.failOnViolation>false
</maven-checkstyle-plugin.failOnViolation>
<maven-checkstyle-plugin.includeTestSourceDirectory>false
</maven-checkstyle-plugin.includeTestSourceDirectory>
<spring-cloud-build-checkstyle.branch>master</spring-cloud-build-checkstyle.branch>
<checkstyle.suppressions.file>https://raw.githubusercontent.com/spring-cloud/spring-cloud-build/${spring-cloud-build-checkstyle.branch}/spring-cloud-build-tools/src/checkstyle/checkstyle-suppressions.xml</checkstyle.suppressions.file>
</properties>
<dependencyManagement>
<dependencies>
@@ -333,10 +337,11 @@ limitations under the License.
<configuration>
<configLocation>checkstyle.xml</configLocation>
<headerLocation>checkstyle-header.txt</headerLocation>
<propertyExpansion>checkstyle.build.directory=${project.build.directory}</propertyExpansion>
<propertyExpansion>checkstyle.build.directory=${project.build.directory}
checkstyle.suppressions.file=${checkstyle.suppressions.file}</propertyExpansion>
<consoleOutput>true</consoleOutput>
<!-- TODO: Start fixing the errors -->
<includeTestSourceDirectory>false</includeTestSourceDirectory>
<includeTestSourceDirectory>${maven-checkstyle-plugin.includeTestSourceDirectory}</includeTestSourceDirectory>
<failsOnError>${maven-checkstyle-plugin.failsOnError}</failsOnError>
<failOnViolation>${maven-checkstyle-plugin.failOnViolation}</failOnViolation>
</configuration>

5
spring-cloud-build-tools/src/checkstyle/checkstyle-suppressions.xml
View File

@@ -3,7 +3,8 @@
"-//Puppy Crawl//DTD Suppressions 1.1//EN"
"http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
<suppressions>
<suppress files="[\\/]src[\\/]test[\\/]java[\\/]" checks="Javadoc*" />
<suppress files=".*Tests\.java" checks="Javadoc*" />
<suppress files="[\\/]src[\\/]test[\\/](java|groovy)[\\/]" checks="(Javadoc*|HideUtility*)" />
<suppress files=".*samples.*" checks="(Javadoc*|HideUtility*)" />
<suppress files="(.*Tests\.java|.*Tests\.groovy)" checks="Javadoc*" />
<suppress files="generated-sources" checks="[a-zA-Z0-9]*" />
</suppressions>

2
spring-cloud-build-tools/src/main/resources/checkstyle.xml
View File

@@ -5,7 +5,7 @@
<module name="com.puppycrawl.tools.checkstyle.Checker">
<module name="SuppressionFilter">
<property name="file" value="src/checkstyle/checkstyle-suppressions.xml"/>
<property name="file" value="${checkstyle.suppressions.file}"/>
<property name="optional" value="true"/>
</module>