SpringCloud/spring-cloud-circuitbreaker
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Provide defaults in builder so if the user creates a builder without either a circuit breaker config or timeout config we dont throw a NPE

Browse Source
This commit is contained in:
Ryan Baxter
2019-08-08 16:03:06 -04:00
parent a32929a5fd
commit b34e83aeaf
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
spring-cloud-circuitbreaker-resilience4j/src/main/java/org/springframework/cloud/circuitbreaker/resilience4j/Resilience4JConfigBuilder.java
View File

@@ -29,9 +29,9 @@ public class Resilience4JConfigBuilder implements
private String id;
private TimeLimiterConfig timeLimiterConfig;
private TimeLimiterConfig timeLimiterConfig = TimeLimiterConfig.ofDefaults();
private CircuitBreakerConfig circuitBreakerConfig;
private CircuitBreakerConfig circuitBreakerConfig = CircuitBreakerConfig.ofDefaults();
public Resilience4JConfigBuilder(String id) {
this.id = id;
@@ -52,7 +52,6 @@ public class Resilience4JConfigBuilder implements
public Resilience4JCircuitBreakerConfiguration build() {
Resilience4JCircuitBreakerConfiguration config = new Resilience4JCircuitBreakerConfiguration();
config.setId(id);
// TODO null checks?
config.setCircuitBreakerConfig(circuitBreakerConfig);
config.setTimeLimiterConfig(timeLimiterConfig);
return config;