SpringCloud/spring-cloud-commons
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Set discovery client health indicator description included to false.

Browse Source 
see gh-223
This commit is contained in:
Spencer Gibb
2017-06-29 16:24:39 -06:00
parent 78511e19b4
commit 7ae5cc1abd
3 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
spring-cloud-commons/src/main/java/org/springframework/cloud/client/discovery/health/DiscoveryClientHealthIndicatorProperties.java
View File

@@ -10,8 +10,7 @@ public class DiscoveryClientHealthIndicatorProperties {
private boolean enabled = true;
//TODO: change to false in 2.0.0
private boolean includeDescription = true;
private boolean includeDescription = false;
public boolean isEnabled() {
return enabled;

4
spring-cloud-commons/src/test/java/org/springframework/cloud/client/discovery/health/DiscoveryClientHealthIndicatorTests.java
View File

@@ -44,7 +44,7 @@ import static org.mockito.Mockito.mock;
*/
@RunWith(SpringRunner.class)
@SpringBootTest(classes = { DiscoveryClientHealthIndicatorTests.Config.class,
CommonsClientAutoConfiguration.class }, properties = "spring.cloud.discovery.client.health-indicator.include-description:false")
CommonsClientAutoConfiguration.class }, properties = "spring.cloud.discovery.client.health-indicator.include-description:true")
public class DiscoveryClientHealthIndicatorTests {
@Autowired
@@ -95,7 +95,7 @@ public class DiscoveryClientHealthIndicatorTests {
health = this.healthIndicator.health();
Status status = assertHealth(health, Status.UP);
assertEquals("status description was wrong", "",
assertEquals("status description was wrong", "TestDiscoveryClient",
status.getDescription());
}

2
spring-cloud-commons/src/test/java/org/springframework/cloud/client/discovery/health/DiscoveryCompositeHealthIndicatorTests.java
View File

@@ -93,7 +93,7 @@ public class DiscoveryCompositeHealthIndicatorTests {
health = this.healthIndicator.health();
Status status = assertHealth(health, Status.UP);
assertEquals("status description was wrong", "TestDiscoveryClient",
assertEquals("status description was wrong", "",
status.getDescription());
}