SpringCloud/spring-cloud-contract
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #94 from dstepanov/queryParametersEncoding

Browse Source 
Don't escape url query parameter values in spock tests
This commit is contained in:
Olga Maciaszek-Sharma
2015-06-24 10:12:12 +02:00
parent 0f325fce4b 8b44fc046b
commit 2866cdd6f0
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
accurest-core/src/main/groovy/io/codearte/accurest/builder/SpockMethodBodyBuilder.groovy
View File

@@ -121,7 +121,7 @@ class SpockMethodBodyBuilder {
private String buildUrlFromUrlPath(UrlPath urlPath) {
String params = urlPath.queryParameters.parameters.inject([]) { result, param ->
result << "${param.name}=${URLEncoder.encode(resolveParamValue(param).toString(), "UTF8")}"
result << "${param.name}=${resolveParamValue(param).toString()}"
}.join('&')
return "$urlPath.serverValue?$params"
}

3
accurest-core/src/test/groovy/io/codearte/accurest/builder/SpockMethodBuilderSpec.groovy
View File

@@ -259,6 +259,7 @@ class SpockMethodBuilderSpec extends Specification {
parameter 'search': $(client(notMatching(~/^\/[0-9]{2}$/)), server("55"))
parameter 'age': $(client(notMatching("^\\w*\$")), server("99"))
parameter 'name': $(client(matching("Denis.*")), server("Denis.Stepanov"))
parameter 'email': "bob@email.com"
}
}
}
@@ -278,7 +279,7 @@ class SpockMethodBuilderSpec extends Specification {
builder.appendTo(blockBuilder)
def spockTest = blockBuilder.toString()
then:
spockTest.contains('get("/users?limit=10&offset=20&filter=email&sort=name&search=55&age=99&name=Denis.Stepanov")')
spockTest.contains('get("/users?limit=10&offset=20&filter=email&sort=name&search=55&age=99&name=Denis.Stepanov&email=bob@email.com")')
spockTest.contains('responseBody.property1 == "a"')
spockTest.contains('responseBody.property2 == "b"')
}