SpringCloud/spring-cloud-contract
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Configure for WireMockServer instead of port (#812)

Browse Source 
When port = 0, WireMock will assign different ports for admin server and mock server. As a result, the original implementation will send admin requests to mock server, which is wrong behavior.

If this PR got merged, WireMock will directly add stubs instead of sending admin requests, which is correct behavior and also improves performance.
This commit is contained in:
杨博 (Yang Bo)
2018-12-12 02:47:52 +08:00
committed by Marcin Grzejszczak
parent a5fab08712
commit 3c3d3f7b19
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spring-cloud-contract-wiremock/src/main/java/org/springframework/cloud/contract/wiremock/WireMockConfiguration.java
View File

@@ -162,7 +162,7 @@ public class WireMockConfiguration implements SmartLifecycle {
@Override
public void start() {
this.server.start();
WireMock.configureFor("localhost", this.server.port());
WireMock.configureFor(new WireMock(this.server));
this.running = true;
if (log.isDebugEnabled()) {
log.debug("Started WireMock at port [" + this.server.port() + "]. It has ["
@@ -287,4 +287,4 @@ class WireMockProperties {
}
}
}