SpringCloud/spring-cloud-contract
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Does not return a lowercase channel name; fixes gh-781

Browse Source
This commit is contained in:
Marcin Grzejszczak
2018-11-06 16:12:11 +01:00
parent 34c2ed0330
commit 8b869e0c7a
2 changed files with 94 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-cloud-contract-verifier/src/main/java/org/springframework/cloud/contract/verifier/messaging/stream/StreamStubMessages.java
View File

@@ -94,7 +94,7 @@ public class StreamStubMessages implements MessageVerifier<Message<?>> {
log.debug("Found a channel named [{}] with destination [{}]",
entry.getKey(), destination);
}
channels.put(entry.getKey().toLowerCase(), destination);
channels.put(entry.getKey(), destination);
}
}
if (channels.size() == 1) {

93
spring-cloud-contract-verifier/src/test/groovy/org/springframework/cloud/contract/verifier/messaging/stream/StreamStubMessagesSpec.groovy
View File

@@ -106,4 +106,97 @@ class StreamStubMessagesSpec extends Specification {
messageInteraction << [ { StreamStubMessages stream -> stream.send("foo", [:], "verifications")},
{ StreamStubMessages stream -> stream.receive("verifications")}]
}
@Issue("694")
def "should resolve input channel if input and output have same destination and receive is called and channel name is camel case"() {
given:
ApplicationContext applicationContext = Mock(ApplicationContext)
BindingServiceProperties properties = new BindingServiceProperties(
bindings: [
input: new BindingProperties(destination: "verificationsChannel"),
output: new BindingProperties(destination: "verificationsChannel"),
]
)
MessageCollector collector = Stub(MessageCollector)
and:
applicationContext.getBean(BindingServiceProperties) >> properties
applicationContext.getBean(MessageCollector) >> collector
and:
StreamStubMessages messages = new StreamStubMessages(applicationContext)
when:
messages.receive("verificationsChannel")
then:
1 * applicationContext.getBean("input", MessageChannel) >> null
}
@Issue("694")
def "should resolve output channel if input and output have same destination and send is called and channel name is camel case"() {
given:
ApplicationContext applicationContext = Mock(ApplicationContext)
BindingServiceProperties properties = new BindingServiceProperties(
bindings: [
input: new BindingProperties(destination: "verificationsChannel"),
output: new BindingProperties(destination: "verificationsChannel"),
]
)
MessageCollector collector = Stub(MessageCollector)
MessageChannel channel = Stub(MessageChannel)
and:
applicationContext.getBean(BindingServiceProperties) >> properties
applicationContext.getBean(MessageCollector) >> collector
and:
StreamStubMessages messages = new StreamStubMessages(applicationContext)
when:
messages.send("foo", [:], "verificationsChannel")
then:
1 * applicationContext.getBean("output", MessageChannel) >> channel
}
def "should resolve channel via destination for send and receive and channel name is camel case"() {
given:
ApplicationContext applicationContext = Mock(ApplicationContext)
BindingServiceProperties properties = new BindingServiceProperties(
bindings: [
foo: new BindingProperties(destination: "verificationsChannel")
]
)
MessageCollector collector = Stub(MessageCollector)
MessageChannel channel = Stub(MessageChannel)
and:
applicationContext.getBean(BindingServiceProperties) >> properties
applicationContext.getBean(MessageCollector) >> collector
and:
StreamStubMessages messages = new StreamStubMessages(applicationContext)
when:
messageInteraction(messages)
then:
1 * applicationContext.getBean("foo", MessageChannel) >> channel
where:
messageInteraction << [ { StreamStubMessages stream -> stream.send("foo", [:], "verificationsChannel")},
{ StreamStubMessages stream -> stream.receive("verificationsChannel")}]
}
def "should resolve channel via channel name for send and receive and channel name is camel case"() {
given:
ApplicationContext applicationContext = Mock(ApplicationContext)
BindingServiceProperties properties = new BindingServiceProperties(
bindings: [
verificationsChannel: new BindingProperties(destination: "bar")
]
)
MessageCollector collector = Stub(MessageCollector)
MessageChannel channel = Stub(MessageChannel)
and:
applicationContext.getBean(BindingServiceProperties) >> properties
applicationContext.getBean(MessageCollector) >> collector
and:
StreamStubMessages messages = new StreamStubMessages(applicationContext)
when:
messageInteraction(messages)
then:
1 * applicationContext.getBean("verificationsChannel", MessageChannel) >> channel
where:
messageInteraction << [ { StreamStubMessages stream -> stream.send("foo", [:], "verificationsChannel")},
{ StreamStubMessages stream -> stream.receive("verificationsChannel")}]
}
}