SpringCloud/spring-cloud-gateway
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove duplicated DataBuffer that caused leak alert by LocalResponseCache (#2886)

Browse Source 
Having `response.bufferFactory().wrap(byteBuffer)` left the original DataBuffer without calling internally the `release()` method, which also decrease the counter of the incoming references to the object by Netty memory leak control.

This copy is not necessary and it was making Netty losing the object, causing memory Leak alert

[connected #2879]
This commit is contained in:
Ignacio Lozano
2023-03-27 18:04:16 +02:00
committed by GitHub
parent 8abdf4be00
commit 162863020d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/factory/cache/ResponseCacheManager.java vendored
View File

@@ -98,7 +98,7 @@ public class ResponseCacheManager {
return body.map(dataBuffer -> {
ByteBuffer byteBuffer = dataBuffer.toByteBuffer().asReadOnlyBuffer();
cachedResponseBuilder.appendToBody(byteBuffer);
return response.bufferFactory().wrap(byteBuffer);
return dataBuffer;
}).doOnComplete(() -> {
CachedResponse responseToCache = cachedResponseBuilder.timestamp(toProcess.timestamp()).build();
saveMetadataInCache(metadataKey, metadata);