SpringCloud/spring-cloud-gateway
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Updates to instanceof with variable

Browse Source
This commit is contained in:
spencergibb
2023-01-24 15:21:57 -05:00
parent a2e815b30b
commit 4dba8bf1e4
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/factory/CacheRequestBodyGatewayFilterFactory.java
View File

@@ -89,8 +89,8 @@ public class CacheRequestBodyGatewayFilterFactory
//
Object backupCachedBody = exchange.getAttributes()
.get(CACHED_ORIGINAL_REQUEST_BODY_BACKUP_ATTR);
if (backupCachedBody instanceof DataBuffer) {
DataBufferUtils.release((DataBuffer) backupCachedBody);
if (backupCachedBody instanceof DataBuffer dataBuffer) {
DataBufferUtils.release(dataBuffer);
}
});
}));

3
spring-cloud-gateway-server/src/test/java/org/springframework/cloud/gateway/filter/factory/CacheRequestBodyGatewayFilterFactoryTests.java
View File

@@ -175,8 +175,7 @@ public class CacheRequestBodyGatewayFilterFactoryTests extends BaseWebClientTest
return chain.filter(exchange).doAfterTerminate(() -> {
Object o = exchange.getAttributes()
.get(CacheRequestBodyGatewayFilterFactory.CACHED_ORIGINAL_REQUEST_BODY_BACKUP_ATTR);
if (o instanceof PooledDataBuffer) {
PooledDataBuffer dataBuffer = (PooledDataBuffer) o;
if (o instanceof PooledDataBuffer dataBuffer) {
if (dataBuffer.isAllocated()) {
exchange.getResponse().setStatusCode(HttpStatus.INTERNAL_SERVER_ERROR);
fail("DataBuffer is not released");