SpringCloud/spring-cloud-gateway
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix NettyNettyWriteResponseFilter memory leak

Browse Source
This commit is contained in:
yanwenliang
2022-10-29 03:45:16 +08:00
committed by spencergibb
parent 2cf190cabf
commit 53cc68fbf5
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/NettyWriteResponseFilter.java
View File

@@ -66,7 +66,6 @@ public class NettyWriteResponseFilter implements GlobalFilter, Ordered {
// until the NettyRoutingFilter is run
// @formatter:off
return chain.filter(exchange)
.doOnError(throwable -> cleanup(exchange))
.then(Mono.defer(() -> {
Connection connection = exchange.getAttribute(CLIENT_RESPONSE_CONN_ATTR);
@@ -99,7 +98,8 @@ public class NettyWriteResponseFilter implements GlobalFilter, Ordered {
return (isStreamingMediaType(contentType)
? response.writeAndFlushWith(body.map(Flux::just))
: response.writeWith(body));
})).doOnCancel(() -> cleanup(exchange));
})).doOnCancel(() -> cleanup(exchange))
.doOnError(throwable -> cleanup(exchange));
// @formatter:on
}
@@ -121,7 +121,7 @@ public class NettyWriteResponseFilter implements GlobalFilter, Ordered {
private void cleanup(ServerWebExchange exchange) {
Connection connection = exchange.getAttribute(CLIENT_RESPONSE_CONN_ATTR);
if (connection != null && connection.channel().isActive() && !connection.isPersistent()) {
if (connection != null && connection.channel().isActive()) {
connection.dispose();
}
}