SpringCloud/spring-cloud-gateway
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Checks for null value if query parameter does not have a value

Browse Source 
fixes gh-423
This commit is contained in:
Spencer Gibb
2018-07-09 13:09:26 -04:00
parent 6ceb65b7cf
commit c343b0ceec
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-cloud-gateway-core/src/main/java/org/springframework/cloud/gateway/handler/predicate/QueryRoutePredicateFactory.java
View File

@@ -58,7 +58,7 @@ public class QueryRoutePredicateFactory extends AbstractRoutePredicateFactory<Qu
return false;
}
for (String value : values) {
if (value.matches(config.regexp)) {
if (value != null && value.matches(config.regexp)) {
return true;
}
}

10
spring-cloud-gateway-core/src/test/java/org/springframework/cloud/gateway/handler/predicate/QueryRoutePredicateFactoryTests.java
View File

@@ -64,6 +64,16 @@ public class QueryRoutePredicateFactoryTests extends BaseWebClientTests {
.expectHeader().valueEquals(ROUTE_ID_HEADER, "foo_query_param");;
}
@Test
public void emptyQueryParamWorks() {
testClient.get().uri("/get?foo")
.exchange()
.expectStatus().isOk()
.expectHeader().valueEquals(ROUTE_ID_HEADER, "default_path_to_httpbin");;
output.expect(not(containsString("Error applying predicate for route: foo_query_param")));
}
@EnableAutoConfiguration
@SpringBootConfiguration
@Import(DefaultTestConfig.class)