SpringCloud/spring-cloud-gateway
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Check if scheme is localhost and fail

Browse Source 
Fixes gh-2919
This commit is contained in:
sgibb
2024-03-12 02:21:15 -04:00
parent de105a1574
commit c6dbf0ef8e
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/route/Route.java
View File

@@ -187,9 +187,11 @@ public class Route implements Ordered {
this.uri = uri;
String scheme = this.uri.getScheme();
Assert.hasText(scheme, "The parameter [" + this.uri + "] format is incorrect, scheme can not be empty");
if (!scheme.equalsIgnoreCase("forward")) {
Assert.hasText(this.uri.getHost(),
"The parameter [" + this.uri + "] format is incorrect, host can not be empty");
if (scheme.equalsIgnoreCase("localhost")) {
// common error
// TODO: find a general way to detect without breaking existing behavior
throw new IllegalArgumentException(
"The parameter [" + this.uri + "] format is incorrect, scheme can not be localhost");
}
if (this.uri.getPort() < 0 && scheme.startsWith("http")) {
// default known http ports