SpringCloud/spring-cloud-kubernetes
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

kubernetes discovery minor changes part 2 (#1522)

Browse Source 
* minor changes

* minor changes

* minor changes

* minor simplification part 2
This commit is contained in:
erabii
2023-11-30 00:06:07 +02:00
committed by GitHub
parent 9951a65ed3
commit 70d85f6585
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-cloud-kubernetes-discovery/src/main/java/org/springframework/cloud/kubernetes/discovery/KubernetesDiscoveryClient.java
View File

@@ -34,12 +34,15 @@ public class KubernetesDiscoveryClient implements DiscoveryClient {
private final KubernetesDiscoveryClientProperties properties;
private final boolean emptyNamespaces;
public KubernetesDiscoveryClient(RestTemplate rest, KubernetesDiscoveryClientProperties properties) {
if (!StringUtils.hasText(properties.getDiscoveryServerUrl())) {
throw new DiscoveryServerUrlInvalidException();
}
this.rest = rest;
this.properties = properties;
this.emptyNamespaces = properties.getNamespaces().isEmpty();
}
@Override
@@ -68,10 +71,7 @@ public class KubernetesDiscoveryClient implements DiscoveryClient {
}
private boolean matchNamespaces(KubernetesServiceInstance kubernetesServiceInstance) {
if (properties.getNamespaces().isEmpty()) {
return true;
}
return properties.getNamespaces().contains(kubernetesServiceInstance.getNamespace());
return emptyNamespaces || properties.getNamespaces().contains(kubernetesServiceInstance.getNamespace());
}
private boolean matchNamespaces(Service service) {