SpringCloud/spring-cloud-netflix
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #409 from brandon-atkinson/issue-394-remove-deflate

Browse Source 
* issue-394-remove-deflate:
  Removed deflate accept-encoding from outbound requests
This commit is contained in:
Spencer Gibb
2015-06-23 09:51:01 -06:00
parent 58284a4508 80206e6b38
commit 0b925e5afa
2 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/zuul/filters/ProxyRequestHelper.java
View File

@@ -93,7 +93,7 @@ public class ProxyRequestHelper {
for (String header : zuulRequestHeaders.keySet()) {
headers.set(header, zuulRequestHeaders.get(header));
}
headers.set("accept-encoding", "deflate, gzip");
headers.set("accept-encoding", "gzip");
return headers;
}

21
spring-cloud-netflix-core/src/test/java/org/springframework/cloud/netflix/zuul/filters/ProxyRequestHelperTests.java
View File

@@ -16,8 +16,6 @@
package org.springframework.cloud.netflix.zuul.filters;
import java.util.List;
import org.junit.Before;
import org.junit.Test;
import org.mockito.Mock;
@@ -25,8 +23,10 @@ import org.springframework.boot.actuate.trace.TraceRepository;
import org.springframework.mock.web.MockHttpServletRequest;
import org.springframework.util.MultiValueMap;
import static org.junit.Assert.*;
import java.util.List;
import static org.hamcrest.Matchers.*;
import static org.junit.Assert.assertThat;
import static org.mockito.MockitoAnnotations.initMocks;
/**
@@ -65,4 +65,19 @@ public class ProxyRequestHelperTests {
assertThat(missingName, is(nullValue()));
}
@Test
public void buildZuulRequestHeadersRequestsGzipAndOnlyGzip() {
MockHttpServletRequest request = new MockHttpServletRequest("", "/");
ProxyRequestHelper helper = new ProxyRequestHelper();
MultiValueMap<String, String> headers = helper.buildZuulRequestHeaders(request);
List<String> acceptEncodings = headers.get("accept-encoding");
assertThat(acceptEncodings, hasSize(1));
assertThat(acceptEncodings, contains("gzip"));
}
}