SpringCloud/spring-cloud-openfeign
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use Enum.valueOf() instead of case switch

Browse Source 
Fixes gh-156
This commit is contained in:
Dave Syer
2015-01-15 13:35:15 +00:00
parent 6e078a88e8
commit 17484fad3a
1 changed files with 8 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/zuul/filters/route/RibbonRoutingFilter.java
View File

@@ -168,26 +168,20 @@ public class RibbonRoutingFilter extends ZuulFilter {
return requestEntity;
}
Verb getVerb(HttpServletRequest request) {
private Verb getVerb(HttpServletRequest request) {
String sMethod = request.getMethod();
return getVerb(sMethod);
}
Verb getVerb(String sMethod) {
private Verb getVerb(String sMethod) {
if (sMethod == null)
return Verb.GET;
sMethod = sMethod.toLowerCase();
if (sMethod.equals("post"))
return Verb.POST;
if (sMethod.equals("put"))
return Verb.PUT;
if (sMethod.equals("delete"))
return Verb.DELETE;
if (sMethod.equals("options"))
return Verb.OPTIONS;
if (sMethod.equals("head"))
return Verb.HEAD;
return Verb.GET;
try {
return Verb.valueOf(sMethod.toUpperCase());
}
catch (IllegalArgumentException e) {
return Verb.GET;
}
}
private void setResponse(HttpResponse resp) throws ClientException, IOException {