SpringCloud/spring-cloud-openfeign
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve url validation. Fixes gh-873.

Browse Source
This commit is contained in:
Olga MaciaszekSharma
2023-12-04 18:23:04 +01:00
parent d8bb85611e
commit c03f78af46
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientFactoryBean.java
View File

@@ -417,7 +417,7 @@ public class FeignClientFactoryBean
if (LOG.isInfoEnabled()) {
LOG.info("For '" + name + "' URL not provided. Will try picking an instance via load-balancing.");
}
if (!name.startsWith("http")) {
if (!name.startsWith("http://") && !name.startsWith("https://")) {
url = "http://" + name;
}
else {
@@ -426,7 +426,7 @@ public class FeignClientFactoryBean
url += cleanPath();
return (T) loadBalance(builder, context, new HardCodedTarget<>(type, name, url));
}
if (StringUtils.hasText(url) && !url.startsWith("http")) {
if (StringUtils.hasText(url) && !url.startsWith("http://") && !url.startsWith("https://")) {
url = "http://" + url;
}
String url = this.url + cleanPath();