SpringCloud/spring-cloud-openfeign
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1637 from tmack8001/zuul-route-constructor-custom-sensitive-headers

Browse Source 
ZuulProperties.ZuulRoute consturctor missing explicitly setting of customSensitiveHeaders boolean
This commit is contained in:
Ryan Baxter
2017-01-23 09:38:44 -05:00
committed by GitHub
parent 5d0b2fae86 ff0ac568f4
commit ca244c5dbb
2 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/zuul/filters/ZuulProperties.java
View File

@@ -249,6 +249,7 @@ public class ZuulProperties {
this.stripPrefix = stripPrefix;
this.retryable = retryable;
this.sensitiveHeaders = sensitiveHeaders;
this.customSensitiveHeaders = sensitiveHeaders != null;
}
public ZuulRoute(String text) {

16
spring-cloud-netflix-core/src/test/java/org/springframework/cloud/netflix/zuul/filters/ZuulPropertiesTests.java
View File

@@ -72,6 +72,7 @@ public class ZuulPropertiesTests {
assertTrue(this.zuul.getRoutes().get("foo").getSensitiveHeaders().isEmpty());
assertTrue(this.zuul.getSensitiveHeaders()
.containsAll(Arrays.asList("Cookie", "Set-Cookie", "Authorization")));
assertFalse(route.isCustomSensitiveHeaders());
}
@Test
@@ -83,6 +84,21 @@ public class ZuulPropertiesTests {
ZuulRoute foo = this.zuul.getRoutes().get("foo");
assertTrue(foo.getSensitiveHeaders().contains("x-foo"));
assertFalse(foo.getSensitiveHeaders().contains("Cookie"));
assertTrue(foo.isCustomSensitiveHeaders());
assertTrue(this.zuul.getSensitiveHeaders().contains("x-bar"));
assertFalse(this.zuul.getSensitiveHeaders().contains("Cookie"));
}
@Test
public void createWithSensitiveHeaders() {
this.zuul.setSensitiveHeaders(Collections.singleton("x-bar"));
ZuulRoute route = new ZuulRoute("foo", "/path", "foo", "/path",
false, false, Collections.singleton("x-foo"));
this.zuul.getRoutes().put("foo", route);
ZuulRoute foo = this.zuul.getRoutes().get("foo");
assertTrue(foo.getSensitiveHeaders().contains("x-foo"));
assertFalse(foo.getSensitiveHeaders().contains("Cookie"));
assertTrue(foo.isCustomSensitiveHeaders());
assertTrue(this.zuul.getSensitiveHeaders().contains("x-bar"));
assertFalse(this.zuul.getSensitiveHeaders().contains("Cookie"));
}