Ensuring that release versions don't use snapshot versions

without this change we could commit a release version that references a dependency in a snapshot version
with this change an exception will be throw in such a case. Exception will contain a file name together with the line in which a snapshot version was found

fixes #7

README.adoc

@@ -27,7 +27,9 @@ why this tool makes it easy to automate the release / dependency update process
 
 - Clones the Spring Cloud Release project and picks all versions (Boot + Cloud projects)
 - Modifies the project versions with values from SC-Release
-- Performs the build and checks if the `docs` modules have properly created the documentation (no `unresolved` tags are present)
+  * throws an exception when we bump versions to release and there's a SNAPSHOT version referenced in the POM
+- Performs the build and checks if the `docs` modules have properly created the documentation
+  * throws an exception when in the `docs` module there's an unresolved tag in any HTML file
 - Commits changed poms (ONLY FOR NON-SNAPSHOT VERSIONS)
 - Creates a tag for the release / milestone (ONLY FOR NON-SNAPSHOT VERSIONS)
 - Runs the deployment of the artifacts

docs/src/main/asciidoc/spring-cloud-release-tools.adoc

@@ -17,7 +17,9 @@ why this tool makes it easy to automate the release / dependency update process
 
 - Clones the Spring Cloud Release project and picks all versions (Boot + Cloud projects)
 - Modifies the project versions with values from SC-Release
-- Performs the build and checks if the `docs` modules have properly created the documentation (no `unresolved` tags are present)
+  * throws an exception when we bump versions to release and there's a SNAPSHOT version referenced in the POM
+- Performs the build and checks if the `docs` modules have properly created the documentation
+  * throws an exception when in the `docs` module there's an unresolved tag in any HTML file
 - Commits changed poms (ONLY FOR NON-SNAPSHOT VERSIONS)
 - Creates a tag for the release / milestone (ONLY FOR NON-SNAPSHOT VERSIONS)
 - Runs the deployment of the artifacts

spring-cloud-release-tools-core/src/main/java/org/springframework/cloud/release/internal/pom/PomUpdater.java

@@ -36,7 +36,9 @@ import org.codehaus.mojo.versions.rewriting.ModifiedPomXMLEventReader;
 import org.codehaus.stax2.XMLInputFactory2;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.springframework.util.StringUtils;
+
+import static org.springframework.util.StringUtils.hasText;
+import static org.springframework.util.StringUtils.isEmpty;
 
 /**
  * @author Marcin Grzejszczak
@@ -122,7 +124,7 @@ class PomUpdater {
 			Model model, List<VersionChange> sourceChanges) {
 		String rootProjectName = wrapper.projectName();
 		List<VersionChange> changes = new ArrayList<>(sourceChanges);
-		if (model.getParent() == null || StringUtils.isEmpty(model.getParent().getVersion())) {
+		if (model.getParent() == null || isEmpty(model.getParent().getVersion())) {
 			log.debug("Can't set the value for parent... Will return {}", sourceChanges);
 			return changes;
 		}
@@ -132,8 +134,8 @@ class PomUpdater {
 		String oldVersion = model.getParent().getVersion();
 		String version = versions.versionForProject(parentArtifactId);
 		log.debug("Found version is [{}]", version);
-		if (StringUtils.isEmpty(version)) {
-			if (StringUtils.hasText(model.getParent().getRelativePath())) {
+		if (isEmpty(version)) {
+			if (hasText(model.getParent().getRelativePath())) {
 				version = versions.versionForProject(rootProjectName);
 			} else {
 				log.warn("There is no info on the [{}:{}] version", parentGroupId, parentArtifactId);
@@ -146,7 +148,9 @@ class PomUpdater {
 		}
 		log.info("Setting version of parent [{}] to [{}] for module [{}]", parentArtifactId,
 				version, model.getArtifactId());
-		changes.add(new VersionChange(parentGroupId, parentArtifactId, oldVersion, version));
+		if (hasText(version)) {
+			changes.add(new VersionChange(parentGroupId, parentArtifactId, oldVersion, version));
+		}
 		return changes;
 	}
 
@@ -160,7 +164,7 @@ class PomUpdater {
 		String oldVersion = model.getVersion();
 		String version = versions.versionForProject(rootProjectName);
 		log.debug("Found version is [{}]", version);
-		if (StringUtils.isEmpty(version) || StringUtils.isEmpty(model.getVersion())) {
+		if (isEmpty(version) || isEmpty(model.getVersion())) {
 			log.debug("There was no version set for project [{}], skipping version setting for module [{}]", rootProjectName, model.getArtifactId());
 			return changes;
 		}
@@ -174,7 +178,7 @@ class PomUpdater {
 	}
 
 	private String groupId(Model model) {
-		if (StringUtils.hasText(model.getGroupId())) {
+		if (hasText(model.getGroupId())) {
 			return model.getGroupId();
 		}
 		if (model.getParent() != null) {

spring-cloud-release-tools-core/src/main/java/org/springframework/cloud/release/internal/pom/ProjectPomUpdater.java

@@ -24,6 +24,7 @@ import java.nio.file.Path;
 import java.nio.file.SimpleFileVisitor;
 import java.nio.file.attribute.BasicFileAttributes;
 import java.util.HashSet;
+import java.util.Scanner;
 import java.util.Set;
 
 import org.slf4j.Logger;
@@ -103,6 +104,7 @@ public class ProjectPomUpdater {
 		private final Versions versions;
 		private final PomUpdater pomUpdater;
 		private final ReleaserProperties properties;
+		private final boolean snapshotVersion;
 
 		private PomWalker(ModelWrapper rootPom, Versions versions, PomUpdater pomUpdater,
 				ReleaserProperties properties) {
@@ -110,6 +112,7 @@ public class ProjectPomUpdater {
 			this.versions = versions;
 			this.pomUpdater = pomUpdater;
 			this.properties = properties;
+			this.snapshotVersion = versions.isSnapshot();
 		}
 
 		@Override
@@ -122,6 +125,21 @@ public class ProjectPomUpdater {
 				}
 				ModelWrapper model = this.pomUpdater.updateModel(this.rootPom, file, this.versions);
 				this.pomUpdater.overwritePomIfDirty(model, this.versions, file);
+				if (!this.snapshotVersion) {
+					log.debug("Update is a non-snapshot one. Checking if no snapshot versions remained in the pom");
+					Scanner scanner = new Scanner(asString(path));
+					int lineNumber = 0;
+					while (scanner.hasNextLine()) {
+						String line = scanner.nextLine();
+						lineNumber++;
+						boolean containsSnapshot = line.contains("BUILD-SNAPSHOT");
+						if (containsSnapshot) {
+							throw new IllegalStateException("The file [" + path + "] contains a BUILD-SNAPSHOT "
+									+ "version for a non snapshot release in line number [" + lineNumber + "]\n\n" + line);
+						}
+					}
+					log.info("No snapshot versions remained in the pom");
+				}
 			}
 			return FileVisitResult.CONTINUE;
 		}
@@ -130,6 +148,15 @@ public class ProjectPomUpdater {
 			String path = file.getPath();
 			return this.properties.getPom().getIgnoredPomRegex().stream().anyMatch(path::matches);
 		}
+
+		private String asString(Path path) {
+			try {
+				return new String(Files.readAllBytes(path));
+			}
+			catch (IOException e) {
+				throw new IllegalStateException(e);
+			}
+		}
 	}
 
 }

spring-cloud-release-tools-core/src/main/java/org/springframework/cloud/release/internal/pom/Versions.java

@@ -89,6 +89,10 @@ class Versions {
 		return project.name.equals(withoutParent);
 	}
 
+	boolean isSnapshot() {
+		return this.projects.stream().anyMatch(project -> project.version.endsWith("BUILD-SNAPSHOT"));
+	}
+
 	@Override public String toString() {
 		return "Spring Boot Version=[" + this.bootVersion + ']' + "\nSpring Cloud Build Version=["
 				+ this.scBuildVersion + ']' + "\nProjects=\n\t" + this.projects.stream().map(Object::toString).collect(

spring-cloud-release-tools-core/src/test/java/org/springframework/cloud/release/internal/PomUpdateAcceptanceTests.java

@@ -6,6 +6,7 @@ import java.net.URISyntaxException;
 import java.nio.file.Files;
 
 import org.apache.maven.model.Model;
+import org.assertj.core.api.BDDAssertions;
 import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
@@ -58,6 +59,17 @@ public class PomUpdateAcceptanceTests {
 		then(zipkinStreamPom.getParent().getVersion()).isEqualTo("1.2.0.BUILD-SNAPSHOT");
 	}
 
+	@Test
+	public void should_update_fail_when_after_updating_a_release_version_there_still_is_a_snapshot_version() throws Exception {
+		ReleaserProperties releaserProperties = branchReleaserProperties();
+		ProjectPomUpdater projectPomUpdater = new ProjectPomUpdater(releaserProperties);
+
+		BDDAssertions.thenThrownBy(() ->
+			projectPomUpdater
+					.updateProjectFromSCRelease(new File(this.temporaryFolder, "/spring-cloud-sleuth-with-unmatched-property"))
+		).hasMessageContaining("<spring-cloud-unmatched.version>0.6.0.BUILD-SNAPSHOT</spring-cloud-unmatched.version>");
+	}
+
 	@Test
 	public void should_not_update_a_project_that_is_not_on_the_list() throws Exception {
 		ReleaserProperties releaserProperties = releaserProperties();
@@ -77,6 +89,12 @@ public class PomUpdateAcceptanceTests {
 		return releaserProperties;
 	}
 
+	private ReleaserProperties branchReleaserProperties() throws URISyntaxException {
+		ReleaserProperties releaserProperties = releaserProperties();
+		releaserProperties.getPom().setBranch("vCamden.SR4");
+		return releaserProperties;
+	}
+
 	private File tmpFile(String relativePath) {
 		return new File(this.temporaryFolder, relativePath);
 	}

spring-cloud-release-tools-core/src/test/java/org/springframework/cloud/release/internal/pom/PomUpdaterTests.java

@@ -36,7 +36,7 @@ import org.springframework.util.FileSystemUtils;
 /**
  * @author Marcin Grzejszczak
  */
-public class ProjectPomUpdaterTests {
+public class PomUpdaterTests {
 
 	Versions versions = new Versions("0.0.1", "0.0.2", projects());
 	PomUpdater pomUpdater = new PomUpdater();
@@ -263,21 +263,6 @@ public class ProjectPomUpdaterTests {
 				.contains("Won't update the version of module");
 	}
 
-	@Test
-	public void should_return_a_change_version() throws Exception {
-		File originalPom = pom("/projects/project/", "pom_matching_artifact_same_version.xml");
-		File pomInTemp = tmpFile("/project/pom_matching_artifact_same_version.xml");
-		ModelWrapper rootPom = model("spring-cloud-sleuth");
-		ModelWrapper model = this.pomUpdater.updateModel(rootPom, pomInTemp, this.versions);
-
-		File storedPom = this.pomUpdater.overwritePomIfDirty(model, this.versions, pomInTemp);
-
-		BDDAssertions.then(asString(storedPom)).isEqualTo(asString(originalPom));
-		BDDAssertions.then(this.capture.toString())
-				.contains("Won't update the version of parent")
-				.contains("Won't update the version of module");
-	}
-
 	Set<Project> projects() {
 		Set<Project> projects = new HashSet<>();
 		projects.add(new Project("spring-cloud-contract", "0.0.2.BUILD-SNAPSHOT"));

spring-cloud-release-tools-core/src/test/java/org/springframework/cloud/release/internal/pom/VersionsTests.java

@@ -21,8 +21,6 @@ import java.util.Properties;
 import java.util.Set;
 
 import org.junit.Test;
-import org.springframework.cloud.release.internal.pom.Project;
-import org.springframework.cloud.release.internal.pom.Versions;
 
 import static org.assertj.core.api.BDDAssertions.then;
 
@@ -77,12 +75,46 @@ public class VersionsTests {
 		then(this.versions.shouldSetProperty(missingProps())).isFalse();
 	}
 
+	@Test
+	public void should_return_true_when_all_versions_are_snapshot() {
+		then(new Versions("", snapshotProjects()).isSnapshot()).isTrue();
+	}
+
+	@Test
+	public void should_return_true_when_there_only_release_versions() {
+		then(new Versions("1.0.0.RELEASE", releaseProjects()).isSnapshot()).isFalse();
+	}
+
+	@Test
+	public void should_return_true_when_there_are_mixed_versions() {
+		then(new Versions("", mixedProjects()).isSnapshot()).isTrue();
+	}
+
 	Set<Project> projects() {
 		Set<Project> projects = new HashSet<>();
 		projects.add(new Project("foo", "bar"));
 		return projects;
 	}
 
+	Set<Project> snapshotProjects() {
+		Set<Project> projects = new HashSet<>();
+		projects.add(new Project("foo", "1.0.0.BUILD-SNAPSHOT"));
+		return projects;
+	}
+
+	Set<Project> releaseProjects() {
+		Set<Project> projects = new HashSet<>();
+		projects.add(new Project("foo", "1.0.0.RELEASE"));
+		return projects;
+	}
+
+	Set<Project> mixedProjects() {
+		Set<Project> projects = new HashSet<>();
+		projects.add(new Project("foo", "1.0.0.BUILD-SNAPSHOT"));
+		projects.add(new Project("fooBar", "1.0.0.RELEASE"));
+		return projects;
+	}
+
 	Properties validProps() {
 		Properties properties = new Properties();
 		properties.setProperty("foo.version", "1.0.0");

spring-cloud-release-tools-core/src/test/resources/projects/spring-cloud-consul/git/COMMIT_EDITMSG

@@ -1 +1 @@
-Initial commit
+Removed deployer

spring-cloud-release-tools-core/src/test/resources/projects/spring-cloud-consul/git/logs/HEAD

@@ -1 +1,2 @@
 0000000000000000000000000000000000000000 2e289de071592d4d361957e59cc0485c5e1941a0 Marcin Grzejszczak <marcin@grzejszczak.pl> 1489136624 +0100	commit (initial): Initial commit
+2e289de071592d4d361957e59cc0485c5e1941a0 386e26ed81099e05b791bbea27a0236abc42a455 Marcin Grzejszczak <marcin@grzejszczak.pl> 1489413813 +0100	commit: Removed deployer

spring-cloud-release-tools-core/src/test/resources/projects/spring-cloud-consul/git/logs/refs/heads/master

@@ -1 +1,2 @@
 0000000000000000000000000000000000000000 2e289de071592d4d361957e59cc0485c5e1941a0 Marcin Grzejszczak <marcin@grzejszczak.pl> 1489136624 +0100	commit (initial): Initial commit
+2e289de071592d4d361957e59cc0485c5e1941a0 386e26ed81099e05b791bbea27a0236abc42a455 Marcin Grzejszczak <marcin@grzejszczak.pl> 1489413813 +0100	commit: Removed deployer

spring-cloud-release-tools-core/src/test/resources/projects/spring-cloud-consul/git/objects/38/6e26ed81099e05b791bbea27a0236abc42a455

@@ -0,0 +1,3 @@
+x
<01><>=
+1<06>s<EFBFBD><73><EFBFBD>$/<2F>&D<><44>l<EFBFBD>A|<7C><><EFBFBD>u<EFBFBD><75>
+<EFBFBD><EFBFBD>`;0<>H<EFBFBD>u<EFBFBD>Q<EFBFBD><51><EFBFBD>X
<01>"q<13><><EFBFBD>sf!K

spring-cloud-release-tools-core/src/test/resources/projects/spring-cloud-consul/git/refs/heads/master

@@ -1 +1 @@
-2e289de071592d4d361957e59cc0485c5e1941a0
+386e26ed81099e05b791bbea27a0236abc42a455

spring-cloud-release-tools-core/src/test/resources/projects/spring-cloud-consul/pom.xml

@@ -24,7 +24,6 @@
 		<spring-cloud-commons.version>1.2.0.BUILD-SNAPSHOT</spring-cloud-commons.version>
 		<spring-cloud-config.version>1.3.0.BUILD-SNAPSHOT</spring-cloud-config.version>
 		<spring-cloud-netflix.version>1.3.0.BUILD-SNAPSHOT</spring-cloud-netflix.version>
-		<spring-cloud-deployer.version>1.0.3.BUILD-SNAPSHOT</spring-cloud-deployer.version>
 		<spring-cloud-stream.version>Chelsea.BUILD-SNAPSHOT</spring-cloud-stream.version>
 		<gson.version>2.3.1</gson.version>
 		<httpclient.version>4.5.2</httpclient.version>

spring-cloud-release-tools-core/src/test/resources/projects/spring-cloud-sleuth-with-unmatched-property/pom.xml

@@ -0,0 +1,378 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+		 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+		 xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+	<modelVersion>4.0.0</modelVersion>
+
+	<artifactId>spring-cloud-sleuth</artifactId>
+	<version>0.2.0.BUILD-SNAPSHOT</version>
+	<packaging>pom</packaging>
+	<name>Spring Cloud Sleuth</name>
+	<description>Spring Cloud Sleuth</description>
+
+	<parent>
+		<groupId>org.springframework.cloud</groupId>
+		<artifactId>spring-cloud-build</artifactId>
+		<version>0.3.1.BUILD-SNAPSHOT</version>
+		<relativePath/>
+		<!-- lookup parent from repository -->
+	</parent>
+
+	<scm>
+		<url>https://github.com/spring-cloud/spring-cloud-sleuth</url>
+		<connection>scm:git:git://github.com/spring-cloud/spring-cloud-sleuth.git</connection>
+		<developerConnection>scm:git:ssh://git@github.com/spring-cloud/spring-cloud-sleuth.git</developerConnection>
+		<tag>HEAD</tag>
+	</scm>
+
+	<modules>
+		<module>spring-cloud-sleuth-dependencies</module>
+		<module>spring-cloud-sleuth-core</module>
+		<module>spring-cloud-sleuth-zipkin</module>
+		<module>spring-cloud-sleuth-stream</module>
+		<module>spring-cloud-sleuth-zipkin-stream</module>
+		<module>spring-cloud-starter-sleuth</module>
+		<module>spring-cloud-starter-zipkin</module>
+		<module>spring-cloud-sleuth-samples</module>
+		<module>docs</module>
+	</modules>
+
+	<build>
+		<pluginManagement>
+			<plugins>
+				<plugin>
+					<groupId>org.apache.maven.plugins</groupId>
+					<artifactId>maven-compiler-plugin</artifactId>
+					<version>3.1</version>
+					<executions>
+						<execution>
+							<id>default-compile</id>
+							<configuration>
+								<showDeprecation>true</showDeprecation>
+								<showWarnings>true</showWarnings>
+								<compilerArguments>
+									<source>${maven.compiler.source}</source>
+									<target>${maven.compiler.target}</target>
+								</compilerArguments>
+							</configuration>
+						</execution>
+						<execution>
+							<id>default-testCompile</id>
+							<configuration>
+								<showDeprecation>true</showDeprecation>
+								<showWarnings>true</showWarnings>
+								<compilerArguments>
+									<source>${maven.compiler.testSource}</source>
+									<target>${maven.compiler.testTarget}</target>
+								</compilerArguments>
+							</configuration>
+						</execution>
+					</executions>
+				</plugin>
+				<plugin>
+					<groupId>org.apache.maven.plugins</groupId>
+					<artifactId>maven-enforcer-plugin</artifactId>
+					<version>1.3.1</version>
+					<executions>
+						<execution>
+							<id>enforce-java</id>
+							<goals>
+								<goal>enforce</goal>
+							</goals>
+							<configuration>
+								<rules>
+									<requireJavaVersion>
+										<version>${maven.compiler.testTarget}</version>
+									</requireJavaVersion>
+								</rules>
+							</configuration>
+						</execution>
+					</executions>
+				</plugin>
+			</plugins>
+		</pluginManagement>
+		<plugins>
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-checkstyle-plugin</artifactId>
+				<version>${checkstyle.version}</version>
+				<dependencies>
+					<dependency>
+						<groupId>org.springframework.cloud</groupId>
+						<artifactId>spring-cloud-build-tools</artifactId>
+						<version>${spring-cloud-build.version}</version>
+					</dependency>
+				</dependencies>
+				<executions>
+					<execution>
+						<id>validate</id>
+						<phase>validate</phase>
+						<configuration>
+							<configLocation>checkstyle.xml</configLocation>
+							<headerLocation>LICENSE.txt</headerLocation>
+							<consoleOutput>true</consoleOutput>
+							<failsOnError>true</failsOnError>
+						</configuration>
+						<goals>
+							<goal>check</goal>
+						</goals>
+					</execution>
+				</executions>
+			</plugin>
+		</plugins>
+	</build>
+
+	<reporting>
+		<plugins>
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-checkstyle-plugin</artifactId>
+				<version>${checkstyle.version}</version>
+				<configuration>
+					<configLocation>checkstyle.xml</configLocation>
+					<headerLocation>LICENSE.txt</headerLocation>
+				</configuration>
+			</plugin>
+		</plugins>
+	</reporting>
+
+	<dependencyManagement>
+		<dependencies>
+			<dependency>
+				<groupId>org.springframework.cloud</groupId>
+				<artifactId>spring-cloud-sleuth-dependencies</artifactId>
+				<version>${project.version}</version>
+				<type>pom</type>
+				<scope>import</scope>
+			</dependency>
+			<dependency>
+				<groupId>org.springframework.cloud</groupId>
+				<artifactId>spring-cloud-netflix-dependencies</artifactId>
+				<version>${spring-cloud-netflix.version}</version>
+				<type>pom</type>
+				<scope>import</scope>
+			</dependency>
+			<dependency>
+				<groupId>org.springframework.cloud</groupId>
+				<artifactId>spring-cloud-commons-dependencies</artifactId>
+				<version>${spring-cloud-commons.version}</version>
+				<type>pom</type>
+				<scope>import</scope>
+			</dependency>
+			<dependency>
+				<groupId>org.springframework.cloud</groupId>
+				<artifactId>spring-cloud-stream-dependencies</artifactId>
+				<version>${spring-cloud-stream.version}</version>
+				<type>pom</type>
+				<scope>import</scope>
+			</dependency>
+			<!-- Spock -->
+			<dependency>
+				<groupId>org.spockframework</groupId>
+				<artifactId>spock-core</artifactId>
+				<version>${spock.version}</version>
+				<scope>test</scope>
+			</dependency>
+			<dependency>
+				<groupId>org.spockframework</groupId>
+				<artifactId>spock-spring</artifactId>
+				<version>${spock.version}</version>
+				<scope>test</scope>
+			</dependency>
+			<dependency>
+				<groupId>cglib</groupId>
+				<artifactId>cglib-nodep</artifactId>
+				<version>3.1</version>
+			</dependency>
+			<dependency>
+				<groupId>org.objenesis</groupId>
+				<artifactId>objenesis</artifactId>
+				<version>2.1</version>
+                <!-- not test because we need it in stream -->
+			</dependency>
+			<dependency>
+				<groupId>org.hamcrest</groupId>
+				<artifactId>hamcrest-core</artifactId>
+				<scope>test</scope>
+			</dependency>
+			<dependency>
+				<groupId>com.jayway.awaitility</groupId>
+				<artifactId>awaitility</artifactId>
+				<version>1.7.0</version>
+				<scope>test</scope>
+			</dependency>
+			<dependency>
+				<groupId>com.github.tomakehurst</groupId>
+				<artifactId>wiremock</artifactId>
+				<version>2.5.1</version>
+				<scope>test</scope>
+			</dependency>
+			<dependency>
+				<groupId>pl.pragmatists</groupId>
+				<artifactId>JUnitParams</artifactId>
+				<version>1.0.6</version>
+				<scope>test</scope>
+			</dependency>
+			<dependency>
+				<groupId>org.assertj</groupId>
+				<artifactId>assertj-core</artifactId>
+				<version>3.6.2</version>
+				<scope>test</scope>
+			</dependency>
+		</dependencies>
+	</dependencyManagement>
+
+	<properties>
+		<maven.compiler.target>1.7</maven.compiler.target>
+		<maven.compiler.source>1.7</maven.compiler.source>
+		<maven.compiler.testTarget>1.8</maven.compiler.testTarget>
+		<maven.compiler.testSource>1.8</maven.compiler.testSource>
+		<surefire.plugin.version>2.19.1</surefire.plugin.version>
+		<checkstyle.version>2.17</checkstyle.version>
+		<spring-cloud-build.version>0.3.1.BUILD-SNAPSHOT</spring-cloud-build.version>
+		<spring-cloud-commons.version>0.2.0.BUILD-SNAPSHOT</spring-cloud-commons.version>
+		<spring-cloud-stream.version>Foo.BUILD-SNAPSHOT</spring-cloud-stream.version>
+		<spring-cloud-netflix.version>0.3.0.BUILD-SNAPSHOT</spring-cloud-netflix.version>
+		<!-- Unmatched project and version -->
+		<spring-cloud-unmatched.version>0.6.0.BUILD-SNAPSHOT</spring-cloud-unmatched.version>
+	</properties>
+
+	<profiles>
+		<profile>
+			<id>spring</id>
+			<repositories>
+				<repository>
+					<id>spring-snapshots</id>
+					<name>Spring Snapshots</name>
+					<url>https://repo.spring.io/libs-snapshot-local</url>
+					<snapshots>
+						<enabled>true</enabled>
+					</snapshots>
+					<releases>
+						<enabled>false</enabled>
+					</releases>
+				</repository>
+				<repository>
+					<id>spring-milestones</id>
+					<name>Spring Milestones</name>
+					<url>https://repo.spring.io/libs-milestone-local</url>
+					<snapshots>
+						<enabled>false</enabled>
+					</snapshots>
+					<releases>
+						<enabled>false</enabled>
+					</releases>
+				</repository>
+				<repository>
+					<id>spring-releases</id>
+					<name>Spring Releases</name>
+					<url>https://repo.spring.io/release</url>
+					<snapshots>
+						<enabled>false</enabled>
+					</snapshots>
+				</repository>
+			</repositories>
+			<pluginRepositories>
+				<pluginRepository>
+					<id>spring-snapshots</id>
+					<name>Spring Snapshots</name>
+					<url>https://repo.spring.io/libs-snapshot-local</url>
+					<snapshots>
+						<enabled>true</enabled>
+					</snapshots>
+					<releases>
+						<enabled>false</enabled>
+					</releases>
+				</pluginRepository>
+				<pluginRepository>
+					<id>spring-milestones</id>
+					<name>Spring Milestones</name>
+					<url>https://repo.spring.io/libs-milestone-local</url>
+					<snapshots>
+						<enabled>false</enabled>
+					</snapshots>
+				</pluginRepository>
+				<pluginRepository>
+					<id>spring-releases</id>
+					<name>Spring Releases</name>
+					<url>https://repo.spring.io/libs-release-local</url>
+					<snapshots>
+						<enabled>false</enabled>
+					</snapshots>
+				</pluginRepository>
+			</pluginRepositories>
+		</profile>
+		<profile>
+			<id>ide</id>
+			<activation>
+				<activeByDefault>false</activeByDefault>
+			</activation>
+			<build>
+				<plugins>
+					<plugin>
+						<groupId>org.apache.maven.plugins</groupId>
+						<artifactId>maven-compiler-plugin</artifactId>
+						<version>3.1</version>
+						<configuration>
+							<source>${maven.compiler.testSource}</source>
+							<target>${maven.compiler.testTarget}</target>
+						</configuration>
+					</plugin>
+				</plugins>
+			</build>
+		</profile>
+		<profile>
+			<id>benchmarks</id>
+			<activation>
+				<activeByDefault>false</activeByDefault>
+			</activation>
+			<modules>
+				<module>benchmarks</module>
+			</modules>
+		</profile>
+		<profile>
+			<id>sonar</id>
+			<build>
+				<plugins>
+					<plugin>
+						<groupId>org.jacoco</groupId>
+						<artifactId>jacoco-maven-plugin</artifactId>
+						<executions>
+							<execution>
+								<id>pre-unit-test</id>
+								<goals>
+									<goal>prepare-agent</goal>
+								</goals>
+								<configuration>
+									<propertyName>surefireArgLine</propertyName>
+									<destFile>${project.build.directory}/jacoco.exec</destFile>
+								</configuration>
+							</execution>
+							<execution>
+								<id>post-unit-test</id>
+								<phase>test</phase>
+								<goals>
+									<goal>report</goal>
+								</goals>
+								<configuration>
+									<!-- Sets the path to the file which contains the execution data. -->
+									<dataFile>${project.build.directory}/jacoco.exec</dataFile>
+								</configuration>
+							</execution>
+						</executions>
+					</plugin>
+					<plugin>
+						<groupId>org.apache.maven.plugins</groupId>
+						<artifactId>maven-surefire-plugin</artifactId>
+						<version>${surefire.plugin.version}</version>
+						<configuration>
+							<!-- Sets the VM argument line used when unit tests are run. -->
+							<argLine>${surefireArgLine}</argLine>
+						</configuration>
+					</plugin>
+				</plugins>
+			</build>
+		</profile>
+	</profiles>
+
+</project>

spring-cloud-release-tools-core/src/test/resources/projects/spring-cloud-sleuth-with-unmatched-property/spring-cloud-sleuth-core/pom.xml

@@ -0,0 +1,165 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+	<modelVersion>4.0.0</modelVersion>
+
+	<artifactId>spring-cloud-sleuth-core</artifactId>
+	<packaging>jar</packaging>
+	<name>Spring Cloud Sleuth Core</name>
+	<description>Spring Cloud Sleuth Core</description>
+
+	<parent>
+		<groupId>org.springframework.cloud</groupId>
+		<artifactId>spring-cloud-sleuth</artifactId>
+		<version>0.2.0.BUILD-SNAPSHOT</version>
+		<relativePath>..</relativePath>
+	</parent>
+
+	<dependencies>
+		<dependency>
+			<groupId>org.springframework.boot</groupId>
+			<artifactId>spring-boot-starter-web</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.boot</groupId>
+			<artifactId>spring-boot-starter-websocket</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.boot</groupId>
+			<artifactId>spring-boot-configuration-processor</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.boot</groupId>
+			<artifactId>spring-boot-starter-actuator</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.cloud</groupId>
+			<artifactId>spring-cloud-commons</artifactId>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.cloud</groupId>
+			<artifactId>spring-cloud-starter-feign</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.cloud</groupId>
+			<artifactId>spring-cloud-starter-zuul</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.integration</groupId>
+			<artifactId>spring-integration-core</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework</groupId>
+			<artifactId>spring-context</artifactId>
+		</dependency>
+		<dependency>
+			<groupId>com.netflix.hystrix</groupId>
+			<artifactId>hystrix-core</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>io.github.openfeign</groupId>
+			<artifactId>feign-core</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>com.netflix.zuul</groupId>
+			<artifactId>zuul-core</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>io.reactivex</groupId>
+			<artifactId>rxjava</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<!-- Instrumentation of the custom Spring Data REST HandlerInterceptors -->
+		<dependency>
+			<groupId>org.springframework.data</groupId>
+			<artifactId>spring-data-rest-webmvc</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>com.squareup.okhttp3</groupId>
+			<artifactId>okhttp</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>org.apache.httpcomponents</groupId>
+			<artifactId>httpclient</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>io.github.openfeign</groupId>
+			<artifactId>feign-okhttp</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>org.aspectj</groupId>
+			<artifactId>aspectjrt</artifactId>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.boot</groupId>
+			<artifactId>spring-boot-starter-test</artifactId>
+			<scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>com.netflix.archaius</groupId>
+			<artifactId>archaius-core</artifactId>
+			<scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>com.squareup.okhttp3</groupId>
+			<artifactId>mockwebserver</artifactId>
+			<version>3.1.2</version>
+			<scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>org.assertj</groupId>
+			<artifactId>assertj-core</artifactId>
+			<scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>com.jayway.awaitility</groupId>
+			<artifactId>awaitility</artifactId>
+			<scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>pl.pragmatists</groupId>
+			<artifactId>JUnitParams</artifactId>
+			<scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.boot</groupId>
+			<artifactId>spring-boot-starter-data-jpa</artifactId>
+			<scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework</groupId>
+			<artifactId>spring-orm</artifactId>
+			<scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.boot</groupId>
+			<artifactId>spring-boot-starter-data-rest</artifactId>
+			<scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>com.h2database</groupId>
+			<artifactId>h2</artifactId>
+			<scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.cloud</groupId>
+			<artifactId>spring-cloud-starter-eureka</artifactId>
+			<scope>test</scope>
+		</dependency>
+	</dependencies>
+
+</project>

spring-cloud-release-tools-core/src/test/resources/projects/spring-cloud-sleuth-with-unmatched-property/spring-cloud-sleuth-dependencies/pom.xml

@@ -0,0 +1,139 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+		 xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+	<modelVersion>4.0.0</modelVersion>
+	<parent>
+		<artifactId>spring-cloud-dependencies-parent</artifactId>
+		<groupId>org.springframework.cloud</groupId>
+		<version>0.3.1.BUILD-SNAPSHOT</version>
+        <relativePath/>
+	</parent>
+	<artifactId>spring-cloud-sleuth-dependencies</artifactId>
+	<version>0.2.0.BUILD-SNAPSHOT</version>
+	<packaging>pom</packaging>
+	<name>spring-cloud-sleuth-dependencies</name>
+	<description>Spring Cloud Sleuth Dependencies</description>
+	<properties>
+		<zipkin.version>1.19.2</zipkin.version>
+		<zipkin-reporter.version>0.6.12</zipkin-reporter.version>
+	</properties>
+	<dependencyManagement>
+		<dependencies>
+			<dependency>
+				<groupId>org.springframework.cloud</groupId>
+				<artifactId>spring-cloud-sleuth-core</artifactId>
+				<version>${project.version}</version>
+			</dependency>
+			<dependency>
+				<groupId>org.springframework.cloud</groupId>
+				<artifactId>spring-cloud-sleuth-zipkin</artifactId>
+				<version>${project.version}</version>
+			</dependency>
+			<dependency>
+				<groupId>org.springframework.cloud</groupId>
+				<artifactId>spring-cloud-sleuth-stream</artifactId>
+				<version>${project.version}</version>
+			</dependency>
+			<dependency>
+				<groupId>org.springframework.cloud</groupId>
+				<artifactId>spring-cloud-sleuth-zipkin-stream</artifactId>
+				<version>${project.version}</version>
+			</dependency>
+			<dependency>
+				<groupId>org.springframework.cloud</groupId>
+				<artifactId>spring-cloud-starter-zipkin</artifactId>
+				<version>${project.version}</version>
+			</dependency>
+			<dependency>
+				<groupId>org.springframework.cloud</groupId>
+				<artifactId>spring-cloud-starter-sleuth</artifactId>
+				<version>${project.version}</version>
+			</dependency>
+			<dependency>
+				<groupId>io.zipkin.java</groupId>
+				<artifactId>zipkin</artifactId>
+				<version>${zipkin.version}</version>
+			</dependency>
+			<dependency>
+				<groupId>io.zipkin.java</groupId>
+				<artifactId>zipkin-server</artifactId>
+				<version>${zipkin.version}</version>
+			</dependency>
+			<dependency>
+				<groupId>io.zipkin.java</groupId>
+				<artifactId>zipkin-autoconfigure-ui</artifactId>
+				<version>${zipkin.version}</version>
+			</dependency>
+			<dependency>
+				<groupId>io.zipkin.java</groupId>
+				<artifactId>zipkin-autoconfigure-storage-mysql</artifactId>
+				<version>${zipkin.version}</version>
+			</dependency>
+			<dependency>
+				<groupId>io.zipkin.java</groupId>
+				<artifactId>zipkin-junit</artifactId>
+				<version>${zipkin.version}</version>
+			</dependency>
+			<dependency>
+				<groupId>io.zipkin.reporter</groupId>
+				<artifactId>zipkin-reporter</artifactId>
+				<version>${zipkin-reporter.version}</version>
+			</dependency>
+		</dependencies>
+	</dependencyManagement>
+	<profiles>
+		<profile>
+			<id>spring</id>
+			<repositories>
+				<repository>
+					<id>spring-snapshots</id>
+					<name>Spring Snapshots</name>
+					<url>https://repo.spring.io/libs-snapshot-local</url>
+					<snapshots>
+						<enabled>true</enabled>
+					</snapshots>
+					<releases>
+						<enabled>false</enabled>
+					</releases>
+				</repository>
+				<repository>
+					<id>spring-milestones</id>
+					<name>Spring Milestones</name>
+					<url>https://repo.spring.io/libs-milestone-local</url>
+					<snapshots>
+						<enabled>false</enabled>
+					</snapshots>
+				</repository>
+				<repository>
+					<id>spring-releases</id>
+					<name>Spring Releases</name>
+					<url>https://repo.spring.io/release</url>
+					<snapshots>
+						<enabled>false</enabled>
+					</snapshots>
+				</repository>
+			</repositories>
+			<pluginRepositories>
+				<pluginRepository>
+					<id>spring-snapshots</id>
+					<name>Spring Snapshots</name>
+					<url>https://repo.spring.io/libs-snapshot-local</url>
+					<snapshots>
+						<enabled>true</enabled>
+					</snapshots>
+					<releases>
+						<enabled>false</enabled>
+					</releases>
+				</pluginRepository>
+				<pluginRepository>
+					<id>spring-milestones</id>
+					<name>Spring Milestones</name>
+					<url>https://repo.spring.io/libs-milestone-local</url>
+					<snapshots>
+						<enabled>false</enabled>
+					</snapshots>
+				</pluginRepository>
+			</pluginRepositories>
+		</profile>
+	</profiles>
+</project>

spring-cloud-release-tools-core/src/test/resources/projects/spring-cloud-sleuth-with-unmatched-property/spring-cloud-sleuth-samples/pom.xml

@@ -0,0 +1,72 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+		 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+		 xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+	<modelVersion>4.0.0</modelVersion>
+
+	<artifactId>spring-cloud-sleuth-samples</artifactId>
+	<packaging>pom</packaging>
+	<name>Spring Cloud Sleuth Samples</name>
+	<description>Spring Cloud Sleuth Samples</description>
+
+	<parent>
+		<groupId>org.springframework.cloud</groupId>
+		<artifactId>spring-cloud-sleuth</artifactId>
+		<version>0.2.0.BUILD-SNAPSHOT</version>
+		<relativePath>..</relativePath>
+	</parent>
+
+	<modules>
+		<module>spring-cloud-sleuth-sample</module>
+		<module>spring-cloud-sleuth-sample-test-core</module>
+		<module>spring-cloud-sleuth-sample-messaging</module>
+		<module>spring-cloud-sleuth-sample-websocket</module>
+		<module>spring-cloud-sleuth-sample-feign</module>
+		<module>spring-cloud-sleuth-sample-ribbon</module>
+		<module>spring-cloud-sleuth-sample-zipkin</module>
+		<module>spring-cloud-sleuth-sample-stream</module>
+		<module>spring-cloud-sleuth-sample-zipkin-stream</module>
+	</modules>
+
+	<build>
+		<pluginManagement>
+			<plugins>
+				<plugin>
+					<!--skip deploy (this is just a test module) -->
+					<artifactId>maven-deploy-plugin</artifactId>
+					<configuration>
+						<skip>true</skip>
+					</configuration>
+				</plugin>
+			</plugins>
+		</pluginManagement>
+	</build>
+
+	<dependencyManagement>
+		<dependencies>
+			<dependency>
+				<groupId>org.springframework.cloud</groupId>
+				<artifactId>spring-cloud-sleuth-dependencies</artifactId>
+				<version>${project.version}</version>
+				<type>pom</type>
+				<scope>import</scope>
+			</dependency>
+			<dependency>
+				<groupId>org.springframework.cloud</groupId>
+				<artifactId>spring-cloud-sleuth-sample-test-core</artifactId>
+				<version>${project.version}</version>
+			</dependency>
+			<dependency>
+				<groupId>io.zipkin.java</groupId>
+				<artifactId>zipkin</artifactId>
+				<version>1.19.2</version>
+			</dependency>
+			<dependency>
+				<groupId>io.zipkin.java</groupId>
+				<artifactId>zipkin-server</artifactId>
+				<version>1.19.2</version>
+			</dependency>
+		</dependencies>
+	</dependencyManagement>
+
+</project>

spring-cloud-release-tools-core/src/test/resources/projects/spring-cloud-sleuth-with-unmatched-property/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin-stream/pom.xml

@@ -0,0 +1,107 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Copyright 2013-2016 the original author or authors.
+  ~
+  ~ Licensed under the Apache License, Version 2.0 (the "License");
+  ~ you may not use this file except in compliance with the License.
+  ~ You may obtain a copy of the License at
+  ~
+  ~      http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+	<modelVersion>4.0.0</modelVersion>
+
+	<artifactId>spring-cloud-sleuth-sample-zipkin-stream</artifactId>
+	<packaging>jar</packaging>
+
+	<name>spring-cloud-sleuth-sample-zipkin-stream</name>
+	<description>Spring Boot Zipkin Server</description>
+
+	<parent>
+		<groupId>org.springframework.cloud</groupId>
+		<artifactId>spring-cloud-sleuth-samples</artifactId>
+		<version>0.2.0.BUILD-SNAPSHOT</version>
+		<relativePath>..</relativePath>
+	</parent>
+
+	<properties>
+		<docker.image.prefix>springio</docker.image.prefix>
+		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+		<java.version>1.8</java.version>
+		<sonar.skip>true</sonar.skip>
+	</properties>
+
+	<dependencies>
+		<dependency>
+			<groupId>org.springframework.boot</groupId>
+			<artifactId>spring-boot-configuration-processor</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.boot</groupId>
+			<artifactId>spring-boot-starter-jdbc</artifactId>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.cloud</groupId>
+			<artifactId>spring-cloud-sleuth-zipkin-stream</artifactId>
+		</dependency>
+		<dependency>
+			<groupId>io.zipkin.java</groupId>
+			<artifactId>zipkin-autoconfigure-ui</artifactId>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.integration</groupId>
+			<artifactId>spring-integration-jmx</artifactId>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.cloud</groupId>
+			<artifactId>spring-cloud-stream-binder-rabbit</artifactId>
+		</dependency>
+		<dependency>
+			<groupId>com.h2database</groupId>
+			<artifactId>h2</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>mysql</groupId>
+			<artifactId>mysql-connector-java</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.cloud</groupId>
+			<artifactId>spring-cloud-stream-test-support</artifactId>
+			<scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.boot</groupId>
+			<artifactId>spring-boot-starter-test</artifactId>
+			<scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>org.springframework.cloud</groupId>
+			<artifactId>spring-cloud-sleuth-sample-test-core</artifactId>
+			<scope>test</scope>
+		</dependency>
+	</dependencies>
+
+	<build>
+		<plugins>
+			<plugin>
+				<groupId>org.springframework.boot</groupId>
+				<artifactId>spring-boot-maven-plugin</artifactId>
+				<configuration>
+					<classifier>exec</classifier>
+				</configuration>
+			</plugin>
+		</plugins>
+	</build>
+
+</project>