SpringCloud/spring-cloud-release-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed release notes generation; fixes #53

Browse Source
This commit is contained in:
Marcin Grzejszczak
2017-10-25 10:25:58 +02:00
parent 8860ef330e
commit 3aa9d7b4c7
3 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spring-cloud-release-tools-core/src/main/java/org/springframework/cloud/release/internal/git/GithubMilestones.java
View File

@@ -96,7 +96,9 @@ class GithubMilestones {
try {
URL url = foundMilestoneUrl(foundMilestone);
log.info("Found a matching milestone with issues URL [{}]", url);
return url.toString().replace("https://api.github.com/repos", "https://github.com") + "?closed=1";
return url.toString()
.replace("https://api.github.com/repos", "https://github.com")
.replace("milestones", "milestone")+ "?closed=1";
}
catch (IOException e) {
throw new IllegalStateException(e);

2
spring-cloud-release-tools-core/src/main/resources/templates/notes.hbs
View File

@@ -2,5 +2,5 @@
{{ date }}
{{#each projects}} - {{name}} `{{version}}` ([issues]({{ closedMilestoneUrl }}))
{{#each projects}} - {{name}} `{{version}}` {{#if closedMilestoneUrl}}([issues]({{ closedMilestoneUrl }})){{/if}}
{{/each}}

2
spring-cloud-release-tools-core/src/test/java/org/springframework/cloud/release/internal/git/GithubMilestonesTests.java
View File

@@ -118,7 +118,7 @@ public class GithubMilestonesTests {
String url = milestones.milestoneUrl(gaSleuthProject());
then(url).isEqualTo("https://github.com/spring-cloud/spring-cloud-sleuth/milestones/33?closed=1");
then(url).isEqualTo("https://github.com/spring-cloud/spring-cloud-sleuth/milestone/33?closed=1");
}
@Test