SpringCloud/spring-cloud-release-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Nbsp for an empty issue list for the release notes; fixes gh-123

Browse Source
This commit is contained in:
Marcin Grzejszczak
2019-03-07 13:26:50 +01:00
parent 9e87362a83
commit 981cc20e6e
3 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-cloud-release-tools-core/src/main/resources/templates/cloud/blog.hbs
View File

@@ -11,7 +11,7 @@ The following modules were updated as part of {{ releaseVersion }}:
| Module | Version | Issues
|--- |--- |--- |---
{{#each projects}}| {{name}} | {{version}} | {{#if closedMilestoneUrl}}([issues]({{{ closedMilestoneUrl }}})){{/if}}
{{#each projects}}| {{name}} | {{version}} | {{#if closedMilestoneUrl}}([issues]({{{ closedMilestoneUrl }}})){{/if}}{{^closedMilestoneUrl}} {{/closedMilestoneUrl}}
{{/each}}
As always, we welcome feedback on [GitHub](https://github.com/spring-cloud/), on [Gitter](https://gitter.im/spring-cloud/spring-cloud), on [Stack Overflow](http://stackoverflow.com/questions/tagged/spring-cloud), or on [Twitter](https://twitter.com/SpringCloud).

5
spring-cloud-release-tools-core/src/test/java/org/springframework/cloud/release/internal/template/TemplateGeneratorTests.java
View File

@@ -40,6 +40,9 @@ public class TemplateGeneratorTests {
ProjectGitHandler handler = new ProjectGitHandler(this.props) {
@Override
public String milestoneUrl(ProjectVersion releaseVersion) {
if (releaseVersion.projectName.equals("spring-cloud-foo")) {
return "";
}
return "http://foo.bar.com";
}
};
@@ -103,6 +106,7 @@ public class TemplateGeneratorTests {
{
add(new ProjectVersion("spring-cloud-sleuth", "1.0.0.RELEASE"));
add(new ProjectVersion("spring-cloud-consul", "1.0.1.RELEASE"));
add(new ProjectVersion("spring-cloud-foo", "1.0.2.RELEASE"));
}
});
@@ -115,6 +119,7 @@ public class TemplateGeneratorTests {
.contains("### Spring Cloud Sleuth")
.contains(
"| Spring Cloud Sleuth | 1.0.0.RELEASE | ([issues](http://foo.bar.com))")
.contains("| Spring Cloud Foo\t| 1.0.2.RELEASE\t|  ")
.contains("<version>Dalston.RELEASE</version>").contains(
"mavenBom 'org.springframework.cloud:spring-cloud-dependencies:Dalston.RELEASE'");
}

4
spring-cloud-release-tools-spring/src/main/java/org/springframework/cloud/release/internal/ReleaserApplication.java
View File

@@ -64,7 +64,9 @@ public class ReleaserApplication implements CommandLineRunner {
application.run(args);
}
catch (MakeBuildUnstableException ex) {
log.error("[BUILD UNSTABLE] The following exceptions took place in the post release process", ex);
log.error(
"[BUILD UNSTABLE] The following exceptions took place in the post release process",
ex);
log.error(
"[BUILD UNSTABLE] The release happened successfully, but there were post release issues");
log.error("[BUILD UNSTABLE] An exception that should make "