SpringCloud/spring-cloud-release-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't bump sc-build; fixes gh-105

Browse Source
This commit is contained in:
Marcin Grzejszczak
2018-10-24 11:03:17 +02:00
parent d9a586f2a2
commit a39c179b34
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
spring-cloud-release-tools-core/src/main/java/org/springframework/cloud/release/internal/pom/Projects.java
View File

@@ -28,7 +28,6 @@ public class Projects extends HashSet<ProjectVersion> {
Projects newProjects = new Projects();
newProjects.add(new ProjectVersion(originalVersion.projectName, originalVersion.bumpedVersion()));
newProjects.addAll(projects.forNameStartingWith(SpringCloudConstants.SPRING_BOOT));
newProjects.add(projects.forName(SpringCloudConstants.BUILD_ARTIFACT_ID));
return newProjects;
}

3
spring-cloud-release-tools-core/src/test/java/org/springframework/cloud/release/internal/pom/ProjectsTests.java
View File

@@ -56,7 +56,7 @@ public class ProjectsTests {
@Test
public void should_create_project_with_bumped_original_version_and_original_parent_versions() {
Set<ProjectVersion> projectVersions = new HashSet<>();
ProjectVersion build = new ProjectVersion("spring-cloud-build", "1.0.0");
ProjectVersion build = new ProjectVersion("spring-cloud-build", "1.0.0.RELEASE");
projectVersions.add(build);
ProjectVersion boot = new ProjectVersion("spring-boot-starter", "2.0.0");
projectVersions.add(boot);
@@ -68,7 +68,6 @@ public class ProjectsTests {
Projects forRollback = Projects.forRollback(projects, original);
then(forRollback.forName("spring-cloud-build").version).isEqualTo("1.0.0");
then(forRollback.forName("spring-boot-starter").version).isEqualTo("2.0.0");
then(forRollback.forName("spring-boot-dependencies").version).isEqualTo("2.0.0");
then(forRollback.forName("spring-cloud-starter-foo").version).isEqualTo("3.0.1.BUILD-SNAPSHOT");