Fix NPE in SkipPatternSampler (#2089)

This commit is contained in:
Sanha Lee
2022-01-03 20:06:33 +09:00
committed by GitHub
parent 421c5e6476
commit 03e498400b
2 changed files with 16 additions and 0 deletions

View File

@@ -34,6 +34,10 @@ abstract class SkipPatternSampler implements SamplerFunction<HttpRequest> {
@Override
public final Boolean trySample(HttpRequest request) {
String url = request.path();
if (url == null) {
return null;
}
boolean shouldSkip = pattern().matcher(url).matches();
if (shouldSkip) {
return false;

View File

@@ -86,4 +86,16 @@ public class SkipPatternSamplerTests {
then(sampler.trySample(this.request)).isFalse();
}
@Test
public void should_delegate_sampling_decision_if_path_is_null() {
BDDMockito.given(this.request.path()).willReturn(null);
SkipPatternSampler sampler = new SkipPatternSampler() {
@Override
Pattern getPattern() {
return Pattern.compile("foo");
}
};
then(sampler.trySample(this.request)).isNull();
}
}