Fix NPE in SkipPatternSampler (#2089)
This commit is contained in:
@@ -34,6 +34,10 @@ abstract class SkipPatternSampler implements SamplerFunction<HttpRequest> {
|
||||
@Override
|
||||
public final Boolean trySample(HttpRequest request) {
|
||||
String url = request.path();
|
||||
if (url == null) {
|
||||
return null;
|
||||
}
|
||||
|
||||
boolean shouldSkip = pattern().matcher(url).matches();
|
||||
if (shouldSkip) {
|
||||
return false;
|
||||
|
||||
@@ -86,4 +86,16 @@ public class SkipPatternSamplerTests {
|
||||
then(sampler.trySample(this.request)).isFalse();
|
||||
}
|
||||
|
||||
@Test
|
||||
public void should_delegate_sampling_decision_if_path_is_null() {
|
||||
BDDMockito.given(this.request.path()).willReturn(null);
|
||||
SkipPatternSampler sampler = new SkipPatternSampler() {
|
||||
@Override
|
||||
Pattern getPattern() {
|
||||
return Pattern.compile("foo");
|
||||
}
|
||||
};
|
||||
|
||||
then(sampler.trySample(this.request)).isNull();
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user