Merge branch 'gh-2045' of https://github.com/ThomasVitale/spring-cloud-sleuth into ThomasVitale-gh-2045

This commit is contained in:
Marcin Grzejszczak
2021-11-22 14:44:29 +01:00
6 changed files with 21 additions and 21 deletions

View File

@@ -32,8 +32,8 @@ import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
import org.springframework.boot.autoconfigure.data.redis.RedisAutoConfiguration;
import org.springframework.boot.context.properties.EnableConfigurationProperties;
import org.springframework.cloud.sleuth.autoconfig.brave.BraveAutoConfiguration;
import org.springframework.cloud.sleuth.brave.instrument.redis.ClientResourcesBuilderCustomizer;
import org.springframework.cloud.sleuth.brave.instrument.redis.TraceLettuceClientResourcesBuilderCustomizer;
import org.springframework.cloud.sleuth.instrument.redis.ClientResourcesBuilderCustomizer;
import org.springframework.cloud.sleuth.instrument.redis.TraceLettuceClientResourcesBuilderCustomizer;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
@@ -66,7 +66,9 @@ public class BraveRedisAutoConfiguration {
TraceLettuceClientResourcesBuilderCustomizer traceLettuceClientResourcesBuilderCustomizer(Tracing tracing,
TraceRedisProperties traceRedisProperties, Sampler sampler) {
eagerlyInitializePotentiallyRefreshScopeSampler(sampler);
return new TraceLettuceClientResourcesBuilderCustomizer(tracing, traceRedisProperties.getRemoteServiceName());
BraveTracing braveTracing = BraveTracing.builder().tracing(tracing).excludeCommandArgsFromSpanTags()
.serviceName(traceRedisProperties.getRemoteServiceName()).build();
return new TraceLettuceClientResourcesBuilderCustomizer(braveTracing);
}
/**

View File

@@ -33,7 +33,7 @@ import org.springframework.beans.BeansException;
import org.springframework.beans.factory.BeanFactory;
import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.cloud.sleuth.autoconfig.brave.instrument.redis.TraceRedisProperties;
import org.springframework.cloud.sleuth.brave.instrument.redis.TraceLettuceClientResourcesBuilderCustomizer;
import org.springframework.cloud.sleuth.instrument.redis.TraceLettuceClientResourcesBuilderCustomizer;
import org.springframework.cloud.sleuth.internal.ContextUtil;
/**

View File

@@ -301,12 +301,6 @@
</exclusion>
</exclusions>
</dependency>
<!-- Instrumentation of Lettuce -->
<dependency>
<groupId>io.lettuce</groupId>
<artifactId>lettuce-core</artifactId>
<optional>true</optional>
</dependency>
<!-- For Instrumentation of Quartz -->
<dependency>
<groupId>org.springframework.boot</groupId>

View File

@@ -190,6 +190,12 @@
<groupId>org.aspectj</groupId>
<artifactId>aspectjrt</artifactId>
</dependency>
<!-- Instrumentation of Lettuce -->
<dependency>
<groupId>io.lettuce</groupId>
<artifactId>lettuce-core</artifactId>
<optional>true</optional>
</dependency>
<!-- For Instrumentation of Quartz -->
<dependency>
<groupId>org.springframework.boot</groupId>

View File

@@ -14,7 +14,7 @@
* limitations under the License.
*/
package org.springframework.cloud.sleuth.brave.instrument.redis;
package org.springframework.cloud.sleuth.instrument.redis;
import io.lettuce.core.resource.ClientResources;

View File

@@ -14,27 +14,25 @@
* limitations under the License.
*/
package org.springframework.cloud.sleuth.brave.instrument.redis;
package org.springframework.cloud.sleuth.instrument.redis;
import brave.Tracing;
import io.lettuce.core.resource.ClientResources;
import io.lettuce.core.tracing.BraveTracing;
import org.springframework.beans.factory.config.BeanPostProcessor;
import io.lettuce.core.tracing.Tracing;
/**
* {@link BeanPostProcessor} for wrapping Lettuce components in a tracing representation.
* {@link ClientResourcesBuilderCustomizer} for wrapping Lettuce components in a tracing
* representation.
*
* @author Marcin Grzejszczak
* @author Thomas Vitale
* @since 3.0.4
*/
public class TraceLettuceClientResourcesBuilderCustomizer implements ClientResourcesBuilderCustomizer {
private final BraveTracing tracing;
private final Tracing tracing;
public TraceLettuceClientResourcesBuilderCustomizer(Tracing tracing, String serviceName) {
this.tracing = BraveTracing.builder().tracing(tracing).excludeCommandArgsFromSpanTags().serviceName(serviceName)
.build();
public TraceLettuceClientResourcesBuilderCustomizer(Tracing tracing) {
this.tracing = tracing;
}
@Override