SpringCloud/spring-cloud-sleuth
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added Redundant Imports rule for checkstyle

Browse Source
This commit is contained in:
Marcin Grzejszczak
2016-01-20 12:50:18 +01:00
parent 556ff64f99
commit 2698e0b9c2
4 changed files with 16 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
build-tools/src/main/resources/checkstyle.xml
View File

@@ -15,5 +15,6 @@
<property name="ignoreComments" value="true"/>
</module>
<module name="UnusedImports"/>
<module name="RedundantImport"/>
</module>
</module>

1
spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/hystrix/SleuthHystrixAutoConfiguration.java
View File

@@ -3,7 +3,6 @@ package org.springframework.cloud.sleuth.instrument.hystrix;
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
import org.springframework.cloud.sleuth.Tracer;
import org.springframework.cloud.sleuth.Tracer;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;

5
spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/scheduling/TraceSchedulingAspect.java
View File

@@ -21,12 +21,11 @@ import org.aspectj.lang.annotation.Around;
import org.aspectj.lang.annotation.Aspect;
import org.springframework.cloud.sleuth.Span;
import org.springframework.cloud.sleuth.Tracer;
import org.springframework.scheduling.annotation.Scheduled;
/**
* Aspect that creates a new Span for running threads executing methods annotated with
* {@link Scheduled} annotation. For every execution of scheduled method a new trace will
* be started.
* {@link org.springframework.scheduling.annotation.Scheduled} annotation.
* For every execution of scheduled method a new trace will be started.
*
* @author Tomasz Nurkewicz, 4financeIT
* @author Michal Chmielarz, 4financeIT

26
spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/web/TraceWebAspect.java
View File

@@ -16,9 +16,7 @@
package org.springframework.cloud.sleuth.instrument.web;
import java.lang.reflect.Field;
import java.util.concurrent.Callable;
import lombok.extern.apachecommons.CommonsLog;
import org.aspectj.lang.ProceedingJoinPoint;
import org.aspectj.lang.annotation.Around;
import org.aspectj.lang.annotation.Aspect;
@@ -26,29 +24,31 @@ import org.aspectj.lang.annotation.Pointcut;
import org.springframework.cloud.sleuth.TraceAccessor;
import org.springframework.cloud.sleuth.Tracer;
import org.springframework.cloud.sleuth.instrument.TraceCallable;
import org.springframework.stereotype.Controller;
import org.springframework.web.bind.annotation.RestController;
import org.springframework.web.client.RestOperations;
import org.springframework.web.context.request.async.WebAsyncTask;
import lombok.extern.apachecommons.CommonsLog;
import java.lang.reflect.Field;
import java.util.concurrent.Callable;
/**
* Aspect that adds correlation id to
* <p/>
* <ul>
* <li>{@link RestController} annotated classes with public {@link Callable} methods</li>
* <li>{@link Controller} annotated classes with public {@link Callable} methods</li>
* <li>{@link Controller} or {@link RestController} annotated classes with public {@link WebAsyncTask} methods</li>
* <li>{@link org.springframework.web.bind.annotation.RestController} annotated classes
* with public {@link Callable} methods</li>
* <li>{@link org.springframework.stereotype.Controller} annotated classes with public
* {@link Callable} methods</li>
* <li>{@link org.springframework.stereotype.Controller} or
* {@link org.springframework.web.bind.annotation.RestController} annotated classes with
* public {@link WebAsyncTask} methods</li>
* </ul>
* <p/>
* For controllers an around aspect is created that wraps the {@link Callable#call()}
* method execution in {@link TraceCallable}
* <p/>
*
* @see RestController
* @see Controller
* @see RestOperations
* @see org.springframework.web.bind.annotation.RestController
* @see org.springframework.stereotype.Controller
* @see org.springframework.web.client.RestOperations
* @see TraceCallable
* @see Tracer
*