Fix broken test (duh)

This commit is contained in:
Dave Syer
2016-11-15 15:40:06 +00:00
committed by Marcin Grzejszczak
parent ea9553cef7
commit 427df71b76
2 changed files with 14 additions and 15 deletions

View File

@@ -23,8 +23,7 @@ import org.slf4j.MDC;
import org.springframework.cloud.sleuth.Span;
/**
* Span listener that logs to the console when a span got
* started / stopped / continued.
* Span listener that logs to the console when a span got started / stopped / continued.
*
* @author Spencer Gibb
* @since 1.0.0
@@ -36,8 +35,7 @@ public class Slf4jSpanLogger implements SpanLogger {
public Slf4jSpanLogger(String nameSkipPattern) {
this.nameSkipPattern = Pattern.compile(nameSkipPattern);
this.log = org.slf4j.LoggerFactory
.getLogger(Slf4jSpanLogger.class);
this.log = org.slf4j.LoggerFactory.getLogger(Slf4jSpanLogger.class);
}
Slf4jSpanLogger(String nameSkipPattern, Logger log) {
@@ -66,7 +64,9 @@ public class Slf4jSpanLogger implements SpanLogger {
@Override
public void logStoppedSpan(Span parent, Span span) {
log("Stopped span: {}", span);
if (span != null) {
log("Stopped span: {}", span);
}
if (span != null && parent != null) {
log("With parent: {}", parent);
MDC.put(Span.SPAN_ID_NAME, Span.idToHex(parent.getSpanId()));

View File

@@ -18,6 +18,7 @@ package org.springframework.cloud.sleuth.trace;
import java.util.Random;
import java.util.concurrent.Callable;
import org.springframework.cloud.sleuth.Sampler;
import org.springframework.cloud.sleuth.Span;
import org.springframework.cloud.sleuth.SpanNamer;
@@ -104,8 +105,7 @@ public class DefaultTracer implements Tracer {
}
Span cur = SpanContextHolder.getCurrentSpan();
if (!span.equals(cur)) {
ExceptionUtils.warn("Tried to detach trace span but "
+ "it is not the current span: " + span
ExceptionUtils.warn("Tried to detach trace span but " + "it is not the current span: " + span
+ ". You may have forgotten to close or detach " + cur);
}
else {
@@ -122,9 +122,8 @@ public class DefaultTracer implements Tracer {
Span cur = SpanContextHolder.getCurrentSpan();
final Span savedSpan = span.getSavedSpan();
if (!span.equals(cur)) {
ExceptionUtils.warn(
"Tried to close span but it is not the current span: " + span
+ ". You may have forgotten to close or detach " + cur);
ExceptionUtils.warn("Tried to close span but it is not the current span: " + span
+ ". You may have forgotten to close or detach " + cur);
}
else {
span.stop();
@@ -139,10 +138,9 @@ public class DefaultTracer implements Tracer {
}
}
SpanContextHolder.close(new SpanContextHolder.SpanFunction() {
@Override public void apply(Span span) {
if (span!=null) {
DefaultTracer.this.spanLogger.logStoppedSpan(savedSpan, span);
}
@Override
public void apply(Span span) {
DefaultTracer.this.spanLogger.logStoppedSpan(savedSpan, span);
}
});
}
@@ -196,7 +194,8 @@ public class DefaultTracer implements Tracer {
public Span continueSpan(Span span) {
if (span != null) {
this.spanLogger.logContinuedSpan(span);
} else {
}
else {
return null;
}
Span newSpan = createContinuedSpan(span, SpanContextHolder.getCurrentSpan());