SpringCloud/spring-cloud-sleuth
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixing recreation of a random; fixes #728

Browse Source
This commit is contained in:
Marcin Grzejszczak
2017-10-16 09:28:32 +02:00
parent d7cebccf0c
commit 5ec3ca53bf
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/messaging/HeaderBasedMessagingExtractor.java
View File

@@ -15,6 +15,8 @@ import org.springframework.cloud.sleuth.util.TextMapUtil;
*/
public class HeaderBasedMessagingExtractor implements MessagingSpanTextMapExtractor {
private final Random random = new Random();
@Override
public Span joinTrace(SpanTextMap textMap) {
Map<String, String> carrier = TextMapUtil.asMap(textMap);
@@ -37,7 +39,7 @@ public class HeaderBasedMessagingExtractor implements MessagingSpanTextMapExtrac
private String generateTraceIdIfMissing(Map<String, String> carrier,
boolean traceIdMissing) {
if (traceIdMissing) {
carrier.put(TraceMessageHeaders.TRACE_ID_NAME, Span.idToHex(new Random().nextLong()));
carrier.put(TraceMessageHeaders.TRACE_ID_NAME, Span.idToHex(this.random.nextLong()));
}
return carrier.get(TraceMessageHeaders.TRACE_ID_NAME);
}

3
spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/web/ZipkinHttpSpanExtractor.java
View File

@@ -26,6 +26,7 @@ public class ZipkinHttpSpanExtractor implements HttpSpanExtractor {
private static final String HTTP_COMPONENT = "http";
private final Pattern skipPattern;
private final Random random = new Random();
public ZipkinHttpSpanExtractor(Pattern skipPattern) {
this.skipPattern = skipPattern;
@@ -70,7 +71,7 @@ public class ZipkinHttpSpanExtractor implements HttpSpanExtractor {
private void generateIdIfMissing(Map<String, String> carrier, String key) {
if (!carrier.containsKey(key)) {
carrier.put(key, Span.idToHex(new Random().nextLong()));
carrier.put(key, Span.idToHex(this.random.nextLong()));
}
}