SpringCloud/spring-cloud-sleuth
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed not starting of span for @scheduled. fixes gh-1019

Browse Source
This commit is contained in:
Marcin Grzejszczak
2018-06-28 11:33:49 +02:00
parent da1df97327
commit 6488d2206b
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/scheduling/TraceSchedulingAspect.java
View File

@@ -62,7 +62,7 @@ public class TraceSchedulingAspect {
}
String spanName = SpanNameUtil.toLowerHyphen(pjp.getSignature().getName());
Span span = startOrContinueRenamedSpan(spanName);
try(Tracer.SpanInScope ws = this.tracer.withSpanInScope(span)) {
try(Tracer.SpanInScope ws = this.tracer.withSpanInScope(span.start())) {
span.tag(CLASS_KEY, pjp.getTarget().getClass().getSimpleName());
span.tag(METHOD_KEY, pjp.getSignature().getName());
return pjp.proceed();

1
spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/scheduling/TracingOnScheduledTests.java
View File

@@ -92,6 +92,7 @@ public class TracingOnScheduledTests {
then(this.reporter.getSpans().get(0).tags())
.contains(new AbstractMap.SimpleEntry<>("class", "TestBeanWithScheduledMethod"),
new AbstractMap.SimpleEntry<>("method", "scheduledMethod"));
then(this.reporter.getSpans().get(0).durationAsLong()).isGreaterThan(0L);
}
private void differentSpanHasBeenSetThan(final Span spanToCompare) {